r17289 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17288‎ | r17289 | r17290 >
Date:18:17, 29 October 2006
Author:simetrical
Status:old
Tags:
Comment:
* (bug 7745) Add id attribute to search button in Monobook
* Fix a typo and a bogus entry in RELEASE-NOTES
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -167,7 +167,7 @@
168168 if( isset( $this->data['search'] ) ) {
169169 ?> value="<?php $this->text('search') ?>"<?php } ?> />
170170 <input type='submit' name="go" class="searchButton" id="searchGoButton" value="<?php $this->msg('searcharticle') ?>" />&nbsp;
171 - <input type='submit' name="fulltext" class="searchButton" value="<?php $this->msg('searchbutton') ?>" />
 171+ <input type='submit' name="fulltext" class="searchButton" id="mw-searchButton" value="<?php $this->msg('searchbutton') ?>" />
172172 </div></form>
173173 </div>
174174 </div>
Index: trunk/phase3/RELEASE-NOTES
@@ -56,7 +56,7 @@
5757 * (bug 7444) Update namespace translations for Telugu (te), kept old values as
5858 alias for compatibility
5959 * (bug 4525) Move section links down visually to same level as headings
60 - editsection links are now inside the heading elements)
 60+ (editsection links are now inside the heading elements)
6161 * Workaround for http://bugs.php.net/bug.php?id=31892 , PATH_INFO and hence
6262 URLs of the style /index.php/Main_Page were broken on some CGI installations.
6363 * (bug 7623) Validate custom HTML id's correctly in Monobook interface
@@ -64,7 +64,6 @@
6565 * (bug 5795) CSS class added to body based on page name for page-specific
6666 styling
6767 * (bug 6276) Stopped search field from getting too large in Cologne Blue
68 -* Fixed duplicate name/id value of "search" in Cologne Blue
6968 * (bug 7644) User creations that are aborted by hooks shouldn't be counted
7069 against account creations per day limit
7170 * (bug 7636) Show Firefox 2 users "shift-alt" as accesskey prefix
@@ -102,6 +101,7 @@
103102 permission. Patch by Werdna.
104103 * (bug 7741) MATH: fixed broken syntax of underbrace etc. Fixed arrays
105104 * Fix purging for updated SVG files
 105+* (bug 7745) Add id attribute to search button in Monobook
106106
107107
108108 == Languages updated ==