r17075 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r17074‎ | r17075 | r17076 >
Date:05:29, 18 October 2006
Author:nickj
Status:old
Tags:
Comment:
Revert part of r17066 - ParserOptions private variables not being treated as private, reported by Simetrical, may only be experienced when tidy is enabled, I need to grep more in future.
Modified paths:
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -4668,23 +4668,23 @@
46694669 */
46704670 class ParserOptions
46714671 {
4672 - # All variables are private
4673 - private $mUseTeX; # Use texvc to expand <math> tags
4674 - private $mUseDynamicDates; # Use DateFormatter to format dates
4675 - private $mInterwikiMagic; # Interlanguage links are removed and returned in an array
4676 - private $mAllowExternalImages; # Allow external images inline
4677 - private $mAllowExternalImagesFrom; # If not, any exception?
4678 - private $mSkin; # Reference to the preferred skin
4679 - private $mDateFormat; # Date format index
4680 - private $mEditSection; # Create "edit section" links
4681 - private $mNumberHeadings; # Automatically number headings
4682 - private $mAllowSpecialInclusion; # Allow inclusion of special pages
4683 - private $mTidy; # Ask for tidy cleanup
4684 - private $mInterfaceMessage; # Which lang to call for PLURAL and GRAMMAR
4685 - private $mMaxIncludeSize; # Maximum size of template expansions, in bytes
4686 - private $mRemoveComments; # Remove HTML comments. ONLY APPLIES TO PREPROCESS OPERATIONS
 4672+ # All variables are supposed to be private in theory, although in practise this is not the case.
 4673+ var $mUseTeX; # Use texvc to expand <math> tags
 4674+ var $mUseDynamicDates; # Use DateFormatter to format dates
 4675+ var $mInterwikiMagic; # Interlanguage links are removed and returned in an array
 4676+ var $mAllowExternalImages; # Allow external images inline
 4677+ var $mAllowExternalImagesFrom; # If not, any exception?
 4678+ var $mSkin; # Reference to the preferred skin
 4679+ var $mDateFormat; # Date format index
 4680+ var $mEditSection; # Create "edit section" links
 4681+ var $mNumberHeadings; # Automatically number headings
 4682+ var $mAllowSpecialInclusion; # Allow inclusion of special pages
 4683+ var $mTidy; # Ask for tidy cleanup
 4684+ var $mInterfaceMessage; # Which lang to call for PLURAL and GRAMMAR
 4685+ var $mMaxIncludeSize; # Maximum size of template expansions, in bytes
 4686+ var $mRemoveComments; # Remove HTML comments. ONLY APPLIES TO PREPROCESS OPERATIONS
46874687
4688 - private $mUser; # Stored user object, just used to initialise the skin
 4688+ var $mUser; # Stored user object, just used to initialise the skin
46894689
46904690 function getUseTeX() { return $this->mUseTeX; }
46914691 function getUseDynamicDates() { return $this->mUseDynamicDates; }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r17066* Make ParserOptions private variables private....nickj08:49, 17 October 2006