r16954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r16953‎ | r16954 | r16955 >
Date:01:07, 12 October 2006
Author:brion
Status:old
Tags:
Comment:
* (bug 6164) Avoid smashing Cite state if message transformation triggers
during bad image list check, by skipping message transformation.
This isn't a good permanent fix.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImageFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImageFunctions.php
@@ -198,7 +198,7 @@
199199 if( !$badImages ) {
200200 # Build the list now
201201 $badImages = array();
202 - $lines = explode( "\n", wfMsgForContent( 'bad_image_list' ) );
 202+ $lines = explode( "\n", wfMsgForContentNoTrans( 'bad_image_list' ) );
203203 foreach( $lines as $line ) {
204204 # List items only
205205 if ( substr( $line, 0, 1 ) !== '*' ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -36,8 +36,11 @@
3737 * Disable PHP exception backtrace printing unless $wgShowExceptionDetails
3838 is set. Backtraces may contain sensitive information in function call
3939 parameters.
 40+* (bug 6164) Avoid smashing Cite state if message transformation triggers
 41+ during bad image list check, by skipping message transformation.
 42+ This isn't a good permanent fix.
 43+
4044
41 -
4245 == Languages updated ==
4346
4447 * Occitan (oc)

Follow-up revisions

RevisionCommit summaryAuthorDate
r35828Revert r35819 -- broke thumbnailing....brion23:46, 3 June 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r14531Add regression test for bug 6164brion21:11, 1 June 2006
r14532* (bug 6164) Fix regression with <gallery> resetting <ref> statebrion21:22, 1 June 2006