r16523 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r16522‎ | r16523 | r16524 >
Date:16:52, 15 September 2006
Author:rainman
Status:old
Tags:
Comment:

Fixed typo and fixed bug related to articles without cache (in
Article.php $dbw is reused). Added new synonims for __NOTC__.
Modified paths:
  • /branches/SerbianVariants/phase3/includes/Article.php (modified) (history)
  • /branches/SerbianVariants/phase3/languages/Language.php (modified) (history)
  • /branches/SerbianVariants/phase3/languages/MessagesSr_ec.php (modified) (history)
  • /branches/SerbianVariants/phase3/languages/MessagesSr_el.php (modified) (history)

Diff [purge]

Index: branches/SerbianVariants/phase3/includes/Article.php
@@ -329,7 +329,7 @@
330330 $this->mLatest = $data->page_latest;
331331 $this->mNoTitleConvert = $data->page_no_title_convert;
332332
333 - if($this->mNoTitleConvert && sizeof($wgContLang->getVariants())>1)
 333+ if($this->mNoTitleConvert)
334334 $wgContLang->setNoTitleConvert();
335335 } else {
336336 if ( is_object( $this->mTitle ) ) {
@@ -1040,14 +1040,16 @@
10411041 $conditions,
10421042 __METHOD__ );
10431043
 1044+ $succ = $dbw->affectedRows() != 0;
 1045+
10441046 // check if no title magic word has been changed
1045 - if($this->mNoTitleConvert != $this->mNoTitleConvertParser){
 1047+ if($succ && $this->mNoTitleConvert != $this->mNoTitleConvertParser){
10461048 // Clear caches
10471049 Article::onArticleCreate( $this->mTitle );
10481050 }
10491051
10501052 wfProfileOut( __METHOD__ );
1051 - return ( $dbw->affectedRows() != 0 );
 1053+ return $succ;
10521054 }
10531055
10541056 /**
Index: branches/SerbianVariants/phase3/languages/MessagesSr_el.php
@@ -175,7 +175,7 @@
176176 'servername' => array( 0, 'SERVERNAME', 'IMESERVERA' ),
177177 'scriptpath' => array( 0, 'SCRIPTPATH', 'SKRIPTA' ),
178178 'grammar' => array( 0, 'GRAMMAR:', 'GRAMATIKA:' ),
179 - 'notitleconvert' => array( 0, '__NOTITLECONVERT__', '__NOTC__', '__BEZTC__' ),
 179+ 'notitleconvert' => array( 0, '__NOTITLECONVERT__', '__NOTC__', '__БЕЗКН__', '__BEZKN__' ),
180180 'nocontentconvert' => array( 0, '__NOCONTENTCONVERT__', '__NOCC__', '__BEZCC__' ),
181181 'currentweek' => array( 1, 'CURRENTWEEK', 'TRENUTNANEDELjA' ),
182182 'currentdow' => array( 1, 'CURRENTDOW', 'TRENUTNIDOV' ),
Index: branches/SerbianVariants/phase3/languages/Language.php
@@ -738,7 +738,7 @@
739739
740740 function ucwordsCallbackWiki($matches){
741741 global $wikiUpperChars;
742 - return strtr( "$matches[0]" , $wikiUpperChars );
 742+ return strtr( $matches[0] , $wikiUpperChars );
743743 }
744744
745745 function ucfirst( $str ) {
Index: branches/SerbianVariants/phase3/languages/MessagesSr_ec.php
@@ -173,7 +173,7 @@
174174 'servername' => array( 0, 'SERVERNAME', 'ИМЕСЕРВЕРА' ),
175175 'scriptpath' => array( 0, 'SCRIPTPATH', 'СКРИПТА' ),
176176 'grammar' => array( 0, 'GRAMMAR:', 'ГРАМАТИКА:' ),
177 - 'notitleconvert' => array( 0, '__NOTITLECONVERT__', '__NOTC__', '__БЕЗТЦ__' ),
 177+ 'notitleconvert' => array( 0, '__NOTITLECONVERT__', '__NOTC__', '__БЕЗКН__', '__BEZKN__' ),
178178 'nocontentconvert' => array( 0, '__NOCONTENTCONVERT__', '__NOCC__', '__БЕЗЦЦ__' ),
179179 'currentweek' => array( 1, 'CURRENTWEEK', 'ТРЕНУТНАНЕДЕЉА' ),
180180 'currentdow' => array( 1, 'CURRENTDOW', 'ТРЕНУТНИДОВ' ),