r1609 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r1608‎ | r1609 | r1610 >
Date:06:21, 30 August 2003
Author:vibber
Status:old
Tags:
Comment:
Update cache validation timestamp on uploads / re-uploads
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -390,10 +390,13 @@
391391 "img_user_text FROM image WHERE img_name='" . wfStrencode( $name ) . "'";
392392 $res = wfQuery( $sql, $fname );
393393
 394+ $now = wfTimestampNow();
 395+ $won = wfInvertTimestamp( $now );
 396+
394397 if ( 0 == wfNumRows( $res ) ) {
395398 $sql = "INSERT INTO image (img_name,img_size,img_timestamp," .
396399 "img_description,img_user,img_user_text) VALUES ('" .
397 - wfStrencode( $name ) . "',{$size},'" . wfTimestampNow() . "','" .
 400+ wfStrencode( $name ) . "',{$size},'{$now}','" .
398401 wfStrencode( $desc ) . "', '" . $wgUser->getID() .
399402 "', '" . wfStrencode( $wgUser->getName() ) . "')";
400403 wfQuery( $sql, $fname );
@@ -403,8 +406,6 @@
404407 wfStrencode( $name ) . "'";
405408 $res = wfQuery( $sql, $fname );
406409 if ( 0 == wfNumRows( $res ) ) {
407 - $now = wfTimestampNow();
408 - $won = wfInvertTimestamp( $now );
409410 $common =
410411 Namespace::getImage() . ",'" .
411412 wfStrencode( $name ) . "','" .
@@ -413,9 +414,9 @@
414415 "',1";
415416 $sql = "INSERT INTO cur (cur_namespace,cur_title," .
416417 "cur_comment,cur_user,cur_user_text,cur_timestamp,cur_is_new," .
417 - "cur_text,inverse_timestamp) VALUES (" .
 418+ "cur_text,inverse_timestamp,cur_touched) VALUES (" .
418419 $common .
419 - ",'" . wfStrencode( $desc ) . "','{$won}')";
 420+ ",'" . wfStrencode( $desc ) . "','{$won}','{$now}')";
420421 wfQuery( $sql, $fname );
421422 $id = wfInsertId() or 0; # We should throw an error instead
422423 $sql = "INSERT INTO recentchanges (rc_namespace,rc_title,
@@ -445,6 +446,11 @@
446447 wfStrencode( $desc ) . "' WHERE img_name='" .
447448 wfStrencode( $name ) . "'";
448449 wfQuery( $sql, $fname );
 450+
 451+ $sql = "UPDATE cur SET cur_touched='{$now}' WHERE cur_namespace=" .
 452+ Namespace::getImage() . " AND cur_title='" .
 453+ wfStrencode( $name ) . "'";
 454+ wfQuery( $sql, $fname );
449455 }
450456
451457 $log = new LogPage( wfMsg( "uploadlogpage" ), wfMsg( "uploadlogpagetext" ) );

Status & tagging log