r15786 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r15785‎ | r15786 | r15787 >
Date:20:22, 22 July 2006
Author:collinj
Status:old
Tags:
Comment:
* (bug 5456) Separate MediaWiki:Search into messages for both noun and
verb, introduced MediaWiki:Searchbutton
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SpecialSearch.php (modified) (history)
  • /trunk/phase3/languages/Messages.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -165,7 +165,7 @@
166166 if( isset( $this->data['search'] ) ) {
167167 ?> value="<?php $this->text('search') ?>"<?php } ?> />
168168 <input type='submit' name="go" class="searchButton" id="searchGoButton" value="<?php $this->msg('go') ?>" />&nbsp;
169 - <input type='submit' name="fulltext" class="searchButton" value="<?php $this->msg('search') ?>" />
 169+ <input type='submit' name="fulltext" class="searchButton" value="<?php $this->msg('searchbutton') ?>" />
170170 </div></form>
171171 </div>
172172 </div>
Index: trunk/phase3/includes/Skin.php
@@ -803,7 +803,7 @@
804804 . '<input type="text" name="search" size="19" value="'
805805 . htmlspecialchars(substr($search,0,256)) . "\" />\n"
806806 . '<input type="submit" name="go" value="' . wfMsg ('go') . '" />&nbsp;'
807 - . '<input type="submit" name="fulltext" value="' . wfMsg ('search') . "\" />\n</form>";
 807+ . '<input type="submit" name="fulltext" value="' . wfMsg ('searchbutton') . "\" />\n</form>";
808808
809809 return $s;
810810 }
Index: trunk/phase3/includes/SpecialSearch.php
@@ -151,7 +151,7 @@
152152 wfMsg( 'googlesearch',
153153 htmlspecialchars( $term ),
154154 htmlspecialchars( $wgInputEncoding ),
155 - htmlspecialchars( wfMsg( 'search' ) )
 155+ htmlspecialchars( wfMsg( 'searchbutton' ) )
156156 )
157157 );
158158 wfProfileOut( $fname );
Index: trunk/phase3/RELEASE-NOTES
@@ -71,6 +71,8 @@
7272 * Fix regression which allowed some blocked users to create additional accounts
7373 * (bug 6657) Fix Hungarian linktrail
7474 * (bug 6751) Fix preview of blanked section with edit on first preview option
 75+* (bug 5456) Separate MediaWiki:Search into messages for both noun and verb,
 76+ introduced 'MediaWiki:Searchbutton'
7577
7678
7779 == Languages updated ==
Index: trunk/phase3/languages/Messages.php
@@ -172,6 +172,7 @@
173173 'tagline' => 'From {{SITENAME}}',
174174 'help' => 'Help',
175175 'search' => 'Search',
 176+'searchbutton' => '{{int:search}}111', # see bug 5456
176177 'go' => 'Go',
177178 'history' => 'Page history',
178179 'history_short' => 'History',