r15784 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r15783‎ \| r15784 \| r15785 >
Date:	18:32, 22 July 2006
Author:	tstarling
Status:	old
Tags:
Comment:	Compare page title with $wgUser->getTitleKey() not $wgUser->getName(). New talk notifications were being erroneously inserted when a user with spaces in their name edited their own user talk page. Bug had been present for at least 18 months, hidden by the fact that the subsequent page view clears the notification.
Modified paths:	/trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
—	—	@@ -2147,7 +2147,7 @@
2148	2148	# If this is another user's talk page, update newtalk
2149	2149	# Don't do this if $changed = false otherwise some idiot can null-edit a
2150	2150	# load of user talk pages and piss people off
2151		~~- if( $this->mTitle->getNamespace() == NS_USER_TALK && $shortTitle != $wgUser->getName() && $changed ) {~~
	2151	+ if( $this->mTitle->getNamespace() == NS_USER_TALK && $shortTitle != $wgUser->getTitleKey() && $changed ) {
2152	2152	if (wfRunHooks('ArticleEditUpdateNewTalk', array(&$this)) ) {
2153	2153	$other = User::newFromName( $shortTitle );
2154	2154	if( is_null( $other ) && User::isIP( $shortTitle ) ) {