r15507 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r15506‎ | r15507 | r15508 >
Date:18:25, 10 July 2006
Author:brion
Status:old
Tags:
Comment:
* (bug 6299) Maintain parser's revision ID across recursive calls to fix
{{REVISIONID}} when Cite extension is used
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -268,7 +268,10 @@
269269
270270 $this->mOptions = $options;
271271 $this->mTitle =& $title;
272 - $this->mRevisionId = $revid;
 272+ $oldRevisionId = $this->mRevisionId;
 273+ if( $revid !== null ) {
 274+ $this->mRevisionId = $revid;
 275+ }
273276 $this->mOutputType = OT_HTML;
274277
275278 //$text = $this->strip( $text, $this->mStripState );
@@ -349,6 +352,7 @@
350353 wfRunHooks( 'ParserAfterTidy', array( &$this, &$text ) );
351354
352355 $this->mOutput->setText( $text );
 356+ $this->mRevisionId = $oldRevisionId;
353357 wfProfileOut( $fname );
354358
355359 return $this->mOutput;
Index: trunk/phase3/RELEASE-NOTES
@@ -45,6 +45,8 @@
4646 * (bug 6618) Improve permissions/error detection in Special:Lockdb
4747 * Quick hack for extension testing: parser test doesn't create new message
4848 cache object.
 49+* (bug 6299) Maintain parser's revision ID across recursive calls to fix
 50+ {{REVISIONID}} when Cite extension is used
4951
5052
5153 == Languages updated ==

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r15501Add parser test for bug 6299brion17:59, 10 July 2006