r14935 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14934‎ | r14935 | r14936 >
Date:11:09, 23 June 2006
Author:tstarling
Status:old
Tags:
Comment:
bugs!
Modified paths:
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialContributions.php
@@ -79,7 +79,7 @@
8080
8181 function getPreviousOffsetForPaging() {
8282 list( $index, $usercond ) = $this->getUserCond();
83 - $nscond = $this->getNamespace_cond();
 83+ $nscond = $this->getNamespaceCond();
8484
8585 $use_index = $this->dbr->useIndexClause( $index );
8686 extract( $this->dbr->tableNames( 'page', 'revision' ) );
Index: trunk/phase3/includes/Title.php
@@ -2152,11 +2152,11 @@
21532153 /**
21542154 * Get the revision ID of the previous revision
21552155 *
2156 - * @param integer $revId Revision ID. Get the revision that was before this one.
2157 - * @param string $timestamp The timestamp of the current revision, if known
 2156+ * @param integer $revision Revision ID. Get the revision that was before this one.
21582157 * @return interger $oldrevision|false
21592158 */
2160 - function getPreviousRevisionID( $revId, $timestamp = false ) {
 2159+ function getPreviousRevisionID( $revision ) {
 2160+ $dbr =& wfGetDB( DB_SLAVE );
21612161 return $dbr->selectField( 'revision', 'rev_id',
21622162 'rev_page=' . intval( $this->getArticleId() ) .
21632163 ' AND rev_id<' . intval( $revision ) . ' ORDER BY rev_id DESC' );