r14634 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14633‎ | r14634 | r14635 >
Date:08:57, 7 June 2006
Author:brion
Status:old
Tags:
Comment:
Regression fix: installer broken by changes to include system, exceptions, and access modifiers.
Modified paths:
  • /trunk/phase3/config/index.php (modified) (history)
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/index.php
@@ -500,7 +500,6 @@
501501 }
502502 print "<li>Database type: {$conf->DBtype}</li>\n";
503503 $dbclass = 'Database'.ucfirst($conf->DBtype);
504 - require_once("$dbclass.php");
505504 $wgDBtype = $conf->DBtype;
506505 $wgDBadminuser = "root";
507506 $wgDBadminpassword = $conf->RootPW;
@@ -550,7 +549,7 @@
551550 $wgDBadminpassword = $db_pass;
552551 echo( "success.</li>\n" );
553552 $wgDatabase->ignoreErrors( true );
554 - $myver = mysql_get_server_info( $wgDatabase->mConn );
 553+ $myver = $wgDatabase->getServerVersion();
555554 } else {
556555 # There were errors, report them and back out
557556 $ok = false;
@@ -620,7 +619,7 @@
621620 }
622621 print "</li>\n";
623622
624 - @$sel = mysql_select_db( $wgDBname, $wgDatabase->mConn );
 623+ @$sel = $wgDatabase->selectDB( $wgDBname );
625624 if( $sel ) {
626625 print "<li>Database <tt>" . htmlspecialchars( $wgDBname ) . "</tt> exists</li>\n";
627626 } else {
@@ -1424,15 +1423,6 @@
14251424 return false;
14261425 }
14271426
1428 -function get_db_version() {
1429 - global $wgDatabase, $conf;
1430 - if ($conf->DBtype == 'mysql')
1431 - return mysql_get_server_info( $wgDatabase->mConn );
1432 - else if ($conf->DBtype == 'oracle')
1433 - return oci_server_version($wgDatabase->mConn);
1434 - else return 'unknown';
1435 -}
1436 -
14371427 # Test a memcached server
14381428 function testMemcachedServer( $server ) {
14391429 $hostport = explode(":", $server);
Index: trunk/phase3/includes/AutoLoader.php
@@ -45,6 +45,7 @@
4646 'WordLevelDiff' => 'DifferenceEngine.php',
4747 'TableDiffFormatter' => 'DifferenceEngine.php',
4848 'EditPage' => 'EditPage.php',
 49+ 'MWException' => 'Exception.php',
4950 'Exif' => 'Exif.php',
5051 'FormatExif' => 'Exif.php',
5152 'WikiExporter' => 'Export.php',

Status & tagging log