r14628 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14627‎ | r14628 | r14629 >
Date:00:21, 7 June 2006
Author:brion
Status:old
Tags:
Comment:
* (bug 4280) Use 'noindex,nofollow' instead of 'noindex,follow' for default
meta robots tag on diff view and special pages. Should reduce impact of
robots on scrolling special pages, diffs etc on sites where robots.txt
doesn't forbid access.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1438,7 +1438,7 @@
14391439 */
14401440 function markpatrolled() {
14411441 global $wgOut, $wgRequest, $wgUseRCPatrol, $wgUser;
1442 - $wgOut->setRobotpolicy( 'noindex,follow' );
 1442+ $wgOut->setRobotpolicy( 'noindex,nofollow' );
14431443
14441444 # Check RC patrol config. option
14451445 if( !$wgUseRCPatrol ) {
@@ -1487,7 +1487,7 @@
14881488
14891489 if( $this->doWatch() ) {
14901490 $wgOut->setPagetitle( wfMsg( 'addedwatch' ) );
1491 - $wgOut->setRobotpolicy( 'noindex,follow' );
 1491+ $wgOut->setRobotpolicy( 'noindex,nofollow' );
14921492
14931493 $link = $this->mTitle->getPrefixedText();
14941494 $text = wfMsg( 'addedwatchtext', $link );
@@ -1535,7 +1535,7 @@
15361536
15371537 if( $this->doUnwatch() ) {
15381538 $wgOut->setPagetitle( wfMsg( 'removedwatch' ) );
1539 - $wgOut->setRobotpolicy( 'noindex,follow' );
 1539+ $wgOut->setRobotpolicy( 'noindex,nofollow' );
15401540
15411541 $link = $this->mTitle->getPrefixedText();
15421542 $text = wfMsg( 'removedwatchtext', $link );
Index: trunk/phase3/includes/DifferenceEngine.php
@@ -138,7 +138,7 @@
139139 $wgOut->setPageTitle( $oldTitle . ', ' . $newTitle );
140140 }
141141 $wgOut->setSubtitle( wfMsg( 'difference' ) );
142 - $wgOut->setRobotpolicy( 'noindex,follow' );
 142+ $wgOut->setRobotpolicy( 'noindex,nofollow' );
143143
144144 if ( !( $this->mOldPage->userCanRead() && $this->mNewPage->userCanRead() ) ) {
145145 $wgOut->loginToUse();
Index: trunk/phase3/includes/SpecialPage.php
@@ -291,7 +291,7 @@
292292 $retVal = $redir;
293293 } else {
294294 $wgOut->setArticleRelated( false );
295 - $wgOut->setRobotpolicy( 'noindex,follow' );
 295+ $wgOut->setRobotpolicy( 'noindex,nofollow' );
296296 $wgOut->setStatusCode( 404 );
297297 $wgOut->errorpage( 'nosuchspecialpage', 'nospecialpagetext' );
298298 $retVal = false;
@@ -428,7 +428,7 @@
429429 function setHeaders() {
430430 global $wgOut;
431431 $wgOut->setArticleRelated( false );
432 - $wgOut->setRobotPolicy( "noindex,follow" );
 432+ $wgOut->setRobotPolicy( "noindex,nofollow" );
433433 $wgOut->setPageTitle( $this->getDescription() );
434434 }
435435
Index: trunk/phase3/RELEASE-NOTES
@@ -450,6 +450,10 @@
451451 to <div class="center">. <center> is perfectly valid in the target doctype
452452 (XHTML 1.0 Transitional), while the replacement didn't catch all cases and
453453 could even result in invalid output from valid input.
 454+* (bug 4280) Use 'noindex,nofollow' instead of 'noindex,follow' for default
 455+ meta robots tag on diff view and special pages. Should reduce impact of
 456+ robots on scrolling special pages, diffs etc on sites where robots.txt
 457+ doesn't forbid access.
454458
455459
456460 == Compatibility ==

Status & tagging log