r14493 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14492‎ | r14493 | r14494 >
Date:08:05, 31 May 2006
Author:brion
Status:old
Tags:
Comment:
* (bug 6126) Allow fallback to customized primary language when user language
message contains '-'; fixes licenses selector on Commons configuration after
recent addition of the message to Messages.php
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/MessageCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MessageCache.php
@@ -457,7 +457,7 @@
458458 }
459459
460460 # Is this a custom message? Try the default language in the db...
461 - if( $message === false &&
 461+ if( ($message === false || $message === '-' ) &&
462462 !$this->mDisable && $useDB &&
463463 !$isfullkey && ($langcode != $wgContLanguageCode) ) {
464464 $message = $this->getFromCache( $lang->ucfirst( $key ) );
Index: trunk/phase3/RELEASE-NOTES
@@ -388,7 +388,11 @@
389389 * (bug 5127) Auto edit summary when creating redirect page
390390 * (bug 3926) Introduce {{#language:}} magic word
391391 * Fix section links from edit comments for [[:Image:Bla.jpg]] in section titles
 392+* (bug 6126) Allow fallback to customized primary language when user language
 393+ message contains '-'; fixes licenses selector on Commons configuration after
 394+ recent addition of the message to Messages.php
392395
 396+
393397 == Compatibility ==
394398
395399 MediaWiki 1.7 requires PHP 5 (5.1 recommended). PHP 4 is no longer supported.

Status & tagging log