r14419 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14418‎ | r14419 | r14420 >
Date:05:25, 27 May 2006
Author:brion
Status:old
Tags:
Comment:
* Markup anality: escape </ as <\/ in toolbar javascript for pure correctness under HTML-compatible browsers.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1522,15 +1522,15 @@
15231523 'key' => 'M'
15241524 ),
15251525 array( 'image' =>'button_math.png',
1526 - 'open' => "\\<math\\>",
1527 - 'close' => "\\</math\\>",
 1526+ 'open' => "<math>",
 1527+ 'close' => "<\\/math>",
15281528 'sample'=> wfMsg('math_sample'),
15291529 'tip' => wfMsg('math_tip'),
15301530 'key' => 'C'
15311531 ),
15321532 array( 'image' =>'button_nowiki.png',
1533 - 'open' => "\\<nowiki\\>",
1534 - 'close' => "\\</nowiki\\>",
 1533+ 'open' => "<nowiki>",
 1534+ 'close' => "<\\/nowiki>",
15351535 'sample'=> wfMsg('nowiki_sample'),
15361536 'tip' => wfMsg('nowiki_tip'),
15371537 'key' => 'N'
Index: trunk/phase3/RELEASE-NOTES
@@ -355,6 +355,8 @@
356356 * (bug 6102) For consistency with other markup, normalize all HTML-encoded
357357 character entities in URLs, not just ampersands. This allows use of eg
358358 &#61; when making URLs for template parameters.
 359+* Markup anality: escape </ as <\/ in toolbar javascript for pure correctness
 360+ under HTML-compatible browsers.
359361
360362
361363 == Compatibility ==

Status & tagging log