r14270 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14269‎ | r14270 | r14271 >
Date:14:41, 17 May 2006
Author:robchurch
Status:old
Tags:
Comment:
(bug 6001) PAGENAMEE and FULLPAGENAMEE don't work in FULLURL and LOCALURL magic words
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -2622,6 +2622,12 @@
26232623
26242624 if ( $func !== false ) {
26252625 $title = Title::newFromText( $part1 );
 2626+ # Due to order of execution of a lot of bits, the values might be encoded
 2627+ # before arriving here; if that's true, then the title can't be created
 2628+ # and the variable will fail. If we can't get a decent title from the first
 2629+ # attempt, url-decode and try for a second.
 2630+ if( is_null( $title ) )
 2631+ $title = Title::newFromUrl( urldecode( $part1 ) );
26262632 if ( !is_null( $title ) ) {
26272633 if ( $argc > 0 ) {
26282634 $text = $linestart . $title->$func( $args[0] );
Index: trunk/phase3/RELEASE-NOTES
@@ -283,6 +283,8 @@
284284 for a wiki page; galleries in special pages and categories are unaffected)
285285 * Maintenance script to remove orphaned revisions from the database
286286 * (bug 5991) Update for Russian language (ru)
 287+* (bug 6001) PAGENAMEE and FULLPAGENAMEE don't work in FULLURL and LOCALURL magic
 288+ words
287289
288290 == Compatibility ==
289291

Status & tagging log