r14268 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14267‎ | r14268 | r14269 >
Date:13:26, 17 May 2006
Author:nikerabbit
Status:old
Tags:
Comment:
* Some escaping
Modified paths:
  • /trunk/phase3/includes/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -848,11 +848,11 @@
849849
850850 $summary = wfMsg('summary');
851851 $subject = wfMsg('subject');
852 - $minor = wfMsg('minoredit');
853 - $watchthis = wfMsg ('watchthis');
 852+ $minor = wfMsgExt('minoredit', array('parseinline'));
 853+ $watchthis = wfMsgExt('watchthis', array('parseinline'));
854854
855855 $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedText(),
856 - wfMsg('cancel') );
 856+ wfMsgExt('cancel', array('parseinline')) );
857857 $edithelpurl = $sk->makeInternalOrExternalUrl( wfMsgForContent( 'edithelppage' ));
858858 $edithelp = '<a target="helpwindow" href="'.$edithelpurl.'">'.
859859 htmlspecialchars( wfMsg( 'edithelp' ) ).'</a> '.
@@ -1182,7 +1182,7 @@
11831183 $batch->execute();
11841184
11851185 # Construct the HTML
1186 - $outText = '<br />'. wfMsg( 'templatesused' ) . '<ul>';
 1186+ $outText = '<br />'. wfMsgExt( 'templatesused', array( 'parseinline' ) ) . '<ul>';
11871187 foreach ( $templates as $titleObj ) {
11881188 $outText .= '<li>' . $sk->makeLinkObj( $titleObj ) . '</li>';
11891189 }
@@ -1615,8 +1615,8 @@
16161616 $oldtext = $this->mArticle->fetchContent();
16171617 $newtext = $this->mArticle->replaceSection(
16181618 $this->section, $this->textbox1, $this->summary, $this->edittime );
1619 - $oldtitle = wfMsg( 'currentrev' );
1620 - $newtitle = wfMsg( 'yourtext' );
 1619+ $oldtitle = wfMsgExt( 'currentrev', array('parseinline') );
 1620+ $newtitle = wfMsgExt( 'yourtext', array('parseinline') );
16211621 if ( $oldtext !== false || $newtext != '' ) {
16221622 $de = new DifferenceEngine( $this->mTitle );
16231623 $de->setText( $oldtext, $newtext );
Index: trunk/phase3/includes/DifferenceEngine.php
@@ -426,7 +426,7 @@
427427
428428 function localiseLineNumbersCb( $matches ) {
429429 global $wgLang;
430 - return wfMsg( 'lineno', $wgLang->formatNum( $matches[1] ) );
 430+ return wfMsgExt( 'lineno', array('parseinline'), $wgLang->formatNum( $matches[1] ) );
431431 }
432432
433433 /**

Status & tagging log