r14044 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14043‎ | r14044 | r14045 >
Date:23:52, 2 May 2006
Author:brion
Status:old
Tags:
Comment:
* Silently ignore errors on profiling table update.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Profiling.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Profiling.php
@@ -325,6 +325,7 @@
326326 $dbw = & wfGetDB(DB_MASTER);
327327 if (!is_object($dbw))
328328 return false;
 329+ $errorState = $dbw->ignoreErrors( true );
329330 $profiling = $dbw->tableName('profiling');
330331
331332 $name = substr($name, 0, 255);
@@ -343,6 +344,7 @@
344345 // "ON DUPLICATE KEY UPDATE ".
345346 // "pf_count=pf_count + VALUES(pf_count), ".
346347 // "pf_time=pf_time + VALUES(pf_time)";
 348+ $dbw->ignoreErrors( $errorState );
347349 }
348350
349351 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -189,7 +189,9 @@
190190 * (bug 5796) We require MySQL >=4.0.14
191191 * Add 'EmailConfirmed' hook
192192 * New findhooks.php script to find undocumented hooks.
 193+* Silently ignore errors on profiling table update.
193194
 195+
194196 == Compatibility ==
195197
196198 Older PHP 4.2 and 4.1 releases are no longer supported; PHP 4 users must

Status & tagging log