r13945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13944‎ | r13945 | r13946 >
Date:22:43, 29 April 2006
Author:nikerabbit
Status:old
Tags:
Comment:
* (bug 5679) time units are now using local numerals
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)
  • /trunk/phase3/languages/LanguageBn.php (modified) (history)
  • /trunk/phase3/languages/LanguageFa.php (modified) (history)
  • /trunk/phase3/languages/LanguageHi.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -129,11 +129,11 @@
130130 * Updated maintenance/transstat.php so it can show duplicate messages
131131 * Improvements to update scripts; print out the version, check for superuser credentials
132132 before attempting a connection, and produce a friendlier error if the connection fails
133 -* (bug 5005): Fix XHTML <gallery> output.
 133+* (bug 5005) Fix XHTML <gallery> output.
134134 * (bug 5315) "Expires: -1" HTTP header made strictly valid (using 1970 date).
135 -* (bug 4825): note in DefaultSettings.php about 'profiling' table creation
 135+* (bug 4825) note in DefaultSettings.php about 'profiling' table creation
136136 * Remove unneeded extra whitespace at top of Special:Categories
137 -* (bug 5679): format number on timeanddate() calls for fa: hi: bn:.
 137+* (bug 5679) time units are now using local numerals
138138 * (bug 5751) Updates to Portuguese localisation files
139139 * (bug 5741) Introduce {{NUMBEROFUSERS}} magic word
140140 * (bug 93) <nowiki> tags and tildes in templates
Index: trunk/phase3/languages/LanguageFa.php
@@ -106,8 +106,5 @@
107107 # For right-to-left language support
108108 function isRTL() { return true; }
109109
110 - function timeanddate( $ts, $adj = false ) {
111 - return $this->formatNum( Language::timeanddate( $ts, $adj ) );
112 - }
113110 }
114111 ?>
Index: trunk/phase3/languages/LanguageBn.php
@@ -62,10 +62,6 @@
6363 );
6464 }
6565
66 - function timeanddate( $ts, $adj = false ) {
67 - return $this->formatNum( Language::timeanddate( $ts, $adj ) );
68 - }
69 -
7066 }
7167
7268 ?>
Index: trunk/phase3/languages/Language.php
@@ -642,10 +642,14 @@
643643 ? ':'
644644 : $this->timeSeparator( $format );
645645
646 - $t = substr( $ts, 8, 2 ) . $sep . substr( $ts, 10, 2 );
 646+ $hh = $this->formatNum( substr( $ts, 8, 2 ), true );
 647+ $mm = $this->formatNum( substr( $ts, 10, 2 ), true );
 648+ $ss = $this->formatNum( substr( $ts, 12, 2 ), true );
647649
 650+ $t = $hh . $sep . $mm;
 651+
648652 if ( $datePreference == MW_DATE_ISO ) {
649 - $t .= $sep . substr( $ts, 12, 2 );
 653+ $t .= $sep . $ss;
650654 }
651655 return $t;
652656 }
Index: trunk/phase3/languages/LanguageHi.php
@@ -59,10 +59,6 @@
6060 return parent::getMessage($key);
6161 }
6262
63 - function timeanddate( $ts, $adj = false ) {
64 - return $this->formatNum( Language::timeanddate( $ts, $adj ) );
65 - }
66 -
6763 }
6864
6965 ?>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r13908Fix bug #5679: timestamps not rendering in bn:, hi: or fa: numeralshashar20:36, 28 April 2006

Status & tagging log