r13886 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13885‎ | r13886 | r13887 >
Date:14:50, 27 April 2006
Author:nikerabbit
Status:old
Tags:
Comment:
*histlegend is now wikitext
*don't do double escaping
Modified paths:
  • /trunk/phase3/includes/PageHistory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PageHistory.php
@@ -174,7 +174,7 @@
175175 function beginHistoryList() {
176176 global $wgTitle;
177177 $this->lastdate = '';
178 - $s = wfMsgWikiHtml( 'histlegend' );
 178+ $s = wfMsgExt( 'histlegend', array( 'parse') );
179179 $s .= '<form action="' . $wgTitle->escapeLocalURL( '-' ) . '" method="get">';
180180 $prefixedkey = htmlspecialchars($wgTitle->getPrefixedDbKey());
181181
@@ -198,8 +198,6 @@
199199
200200 /** @todo document */
201201 function endHistoryList() {
202 - $last = wfMsg( 'last' );
203 -
204202 $s = '</ul>';
205203 $s .= $this->submitButton( array( 'id' => 'historysubmit' ) );
206204 $s .= '</form>';
@@ -213,9 +211,9 @@
214212 array(
215213 'class' => 'historysubmit',
216214 'type' => 'submit',
217 - 'accesskey' => wfMsgHtml( 'accesskey-compareselectedversions' ),
218 - 'title' => wfMsgHtml( 'tooltip-compareselectedversions' ),
219 - 'value' => wfMsgHtml( 'compareselectedversions' ),
 215+ 'accesskey' => wfMsg( 'accesskey-compareselectedversions' ),
 216+ 'title' => wfMsg( 'tooltip-compareselectedversions' ),
 217+ 'value' => wfMsg( 'compareselectedversions' ),
220218 ) ) )
221219 : '';
222220 }
@@ -251,7 +249,7 @@
252250 $s .= " $link <span class='history-user'>$user</span>";
253251
254252 if( $row->rev_minor_edit ) {
255 - $s .= ' ' . wfElement( 'span', array( 'class' => 'minor' ), wfMsgHtml( 'minoreditletter') );
 253+ $s .= ' ' . wfElement( 'span', array( 'class' => 'minor' ), wfMsg( 'minoreditletter') );
256254 }
257255
258256 $s .= $this->mSkin->revComment( $rev );
@@ -284,7 +282,7 @@
285283
286284 /** @todo document */
287285 function curLink( $rev, $latest ) {
288 - $cur = wfMsgHtml( 'cur' );
 286+ $cur = wfMsgExt( 'cur', array( 'escape') );
289287 if( $latest || !$rev->userCan( MW_REV_DELETED_TEXT ) ) {
290288 return $cur;
291289 } else {
@@ -297,7 +295,7 @@
298296
299297 /** @todo document */
300298 function lastLink( $rev, $next, $counter ) {
301 - $last = htmlspecialchars( wfMsg( 'last' ) );
 299+ $last = wfMsgExt( 'last', array( 'escape' ) );
302300 if( is_null( $next ) ) {
303301 if( $rev->getTimestamp() == $this->getEarliestOffset() ) {
304302 return $last;

Status & tagging log