r13849 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13848‎ | r13849 | r13850 >
Date:19:21, 24 April 2006
Author:hashar
Status:old
Tags:
Comment:
some stuff that need fixing
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -330,6 +330,7 @@
331331
332332 /**
333333 * Some styles that are set by user through the user settings interface.
 334+ * @todo undefined variables (bug #4940)
334335 */
335336 function doGetUserStyles() {
336337 global $wgUser, $wgUser, $wgRequest, $wgTitle, $wgAllowUserCss;
@@ -337,6 +338,7 @@
338339 $s = '';
339340
340341 if( $wgAllowUserCss && $wgUser->isLoggedIn() ) { # logged in
 342+ # FIXME: $action undefined, bug #4940
341343 if($wgTitle->isCssSubpage() && $this->userCanPreview( $action ) ) {
342344 $s .= $wgRequest->getText('wpTextbox1');
343345 } else {

Status & tagging log