r13604 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13603‎ | r13604 | r13605 >
Date:08:27, 12 April 2006
Author:brion
Status:old
Tags:
Comment:
Remove uses of PersistentObject; it's not needed and rather silly.
All of these objects maintain references from the $wgHooks array anyway...
Modified paths:
  • /trunk/extensions/Contributionseditcount/Contributionseditcount.php (modified) (history)
  • /trunk/extensions/HTTPRedirect.php (modified) (history)
  • /trunk/extensions/PageCSS/PageCSS.php (modified) (history)
  • /trunk/extensions/Purge.php (modified) (history)
  • /trunk/extensions/Special_talk.php (modified) (history)
  • /trunk/extensions/Tidy.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contributionseditcount/Contributionseditcount.php
@@ -43,6 +43,7 @@
4444 }
4545 }
4646
47 - new PersistentObject( new Contributionseditcount );
 47+ // Establish a singleton.
 48+ new Contributionseditcount;
4849 }
4950 ?>
Index: trunk/extensions/PageCSS/PageCSS.php
@@ -47,5 +47,6 @@
4848 }
4949 }
5050
51 - new PersistentObject( new CssHook );
 51+ // Establish a singleton.
 52+ new CssHook;
5253 }
Index: trunk/extensions/HTTPRedirect.php
@@ -34,5 +34,6 @@
3535 }
3636 }
3737
38 - new PersistentObject( new HTTPRedirect );
 38+ // Establish a singleton.
 39+ new HTTPRedirect;
3940 }
Index: trunk/extensions/Tidy.php
@@ -79,5 +79,6 @@
8080 }
8181 }
8282
83 - new PersistentObject( new TidyAction );
 83+ // Establish a singleton.
 84+ new TidyAction;
8485 }
Index: trunk/extensions/Special_talk.php
@@ -49,5 +49,6 @@
5050 }
5151 }
5252
53 - new PersistentObject( new SpecialTalk );
 53+ // Establish a singleton.
 54+ new SpecialTalk;
5455 }
Index: trunk/extensions/Purge.php
@@ -50,5 +50,6 @@
5151 }
5252 }
5353
54 - new PersistentObject( new PurgeAction );
 54+ // Establish a singleton.
 55+ new PurgeAction;
5556 }

Status & tagging log