r13515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13514‎ | r13515 | r13516 >
Date:19:54, 5 April 2006
Author:brion
Status:old
Tags:
Comment:
Fix big huge PHP warning error on every page when allow_call_time_pass_reference is off
Modified paths:
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -2613,8 +2613,7 @@
26142614 if ( $colonPos !== false ) {
26152615 $function = strtolower( substr( $part1, 0, $colonPos ) );
26162616 if ( isset( $this->mFunctionHooks[$function] ) ) {
2617 - $funcArgs = $args;
2618 - array_unshift( $funcArgs, &$this, substr( $part1, $colonPos + 1 ) );
 2617+ $funcArgs = array_merge( array( &$this, substr( $part1, $colonPos + 1 ) ), $args );
26192618 $result = call_user_func_array( $this->mFunctionHooks[$function], $funcArgs );
26202619 $found = true;
26212620 if ( is_array( $result ) ) {

Status & tagging log