r13448 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13447‎ | r13448 | r13449 >
Date:02:22, 4 April 2006
Author:brion
Status:old
Tags:
Comment:
* (bug 5355) Include skin name and style JS settings in page source;
fixes regression where Opera 6/7 and KHTML CSS fixes weren't applied
when wikibits.js was moved up before user JS inclusion.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)

Diff [purge]

Property changes on: trunk/phase3/skins/chick/main.css
___________________________________________________________________
Name: svn:executable
11 - *
Index: trunk/phase3/skins/MonoBook.php
@@ -64,6 +64,7 @@
6565 <!--[if IE 7]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE70Fixes.css?1";</style><![endif]-->
6666 <!--[if lt IE 7]><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath') ?>/common/IEFixes.js"></script>
6767 <meta http-equiv="imagetoolbar" content="no" /><![endif]-->
 68+ <script type="<?php $this->text('jsmimetype') ?>">var skin = '<?php $this->text('skinname')?>';var stylepath = '<?php $this->text('stylepath')?>';</script>
6869 <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath' ) ?>/common/wikibits.js"><!-- wikibits js --></script>
6970 <?php if($this->data['jsvarurl' ]) { ?>
7071 <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('jsvarurl' ) ?>"><!-- site js --></script>
Index: trunk/phase3/RELEASE-NOTES
@@ -734,6 +734,9 @@
735735 * (bug 5410) Use namespace name when a custom namespace's nstab-NS message is nonexistent
736736 * (bug 5432) Fix inconsistencies in cookie names when using table prefixes
737737 * Additional protections against HTML breakage in table parsing
 738+* (bug 5355) Include skin name and style JS settings in page source;
 739+ fixes regression where Opera 6/7 and KHTML CSS fixes weren't applied
 740+ when wikibits.js was moved up before user JS inclusion.
738741
739742
740743 === Caveats ===

Status & tagging log