r13308 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13307‎ | r13308 | r13309 >
Date:17:19, 24 March 2006
Author:gabrielwicke
Status:old
Tags:
Comment:
Better support for rtl-in-ltr and ltr-in-rtl nesting. Needs to be tested in IE- if not supported by IE6 adding a class to elements with the dir attribute set in the parser could help
Modified paths:
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -127,19 +127,29 @@
128128 h5 { font-size: 100%; }
129129 h6 { font-size: 80%; }
130130
131 -ul {
 131+ul,
 132+*[dir=ltr] ul {
132133 line-height: 1.5em;
133134 list-style-type: square;
134135 margin: .3em 0 0 1.5em;
135136 padding: 0;
136137 list-style-image: url(bullet.gif);
137138 }
138 -ol {
 139+*[dir=rtl] ul {
 140+ margin-left: 0;
 141+ margin-right: 1.5em;
 142+}
 143+ol,
 144+*[dir=ltr] ol {
139145 line-height: 1.5em;
140146 margin: .3em 0 0 3.2em;
141147 padding: 0;
142148 list-style-image: none;
143149 }
 150+*[dir=rtl] ol {
 151+ margin-left: 0;
 152+ margin-right: 2.4em;
 153+}
144154 li {
145155 margin-bottom: .1em;
146156 }
@@ -151,11 +161,17 @@
152162 margin-top: .2em;
153163 margin-bottom: .5em;
154164 }
155 -dd {
 165+dd,
 166+*[dir=ltr] dd {
156167 line-height: 1.5em;
157168 margin-left: 2em;
 169+ margin-right: 0;
158170 margin-bottom: .1em;
159171 }
 172+*[dir=rtl] dd {
 173+ margin-left: 0;
 174+ margin-right: 1.6em;
 175+}
160176
161177 fieldset {
162178 border: 1px solid #2f6fab;
@@ -386,7 +402,10 @@
387403 }
388404
389405 /* images */
390 -div.floatright, table.floatright {
 406+div.floatright,
 407+*[dir=ltr] div.floatright,
 408+table.floatright,
 409+*[dir=ltr] table.floatright {
391410 clear: right;
392411 float: right;
393412 position: relative;
@@ -398,7 +417,10 @@
399418 */
400419 }
401420 div.floatright p { font-style: italic; }
402 -div.floatleft, table.floatleft {
 421+div.floatleft,
 422+*[dir=ltr] div.floatleft,
 423+table.floatleft,
 424+*[dir=ltr] table.floatleft {
403425 float: left;
404426 position: relative;
405427 margin: 0 .5em .5em 0;
@@ -444,17 +466,28 @@
445467 border: none !important;
446468 background: none !important;
447469 }
448 -div.tright {
 470+div.tright,
 471+*[dir=ltr] div.tright {
449472 clear: right;
450473 float: right;
451474 border-width: .5em 0 .8em 1.4em;
452475 }
453 -div.tleft {
 476+*[dir=rtl] div.tright,
 477+*[dir=rtl] div.floatright,
 478+*[dir=rtl] table.floatright {
 479+ clear:none;
 480+}
 481+div.tleft,
 482+*[dir=ltr] div.tleft {
454483 float: left;
455484 margin-right: .5em;
456485 border-width: .5em 1.4em .8em 0;
457486 }
458 -
 487+*[dir=rtl] div.tleft,
 488+*[dir=rtl] div.floatleft,
 489+*[dir=rtl] table.floatleft {
 490+ clear: left;
 491+}
459492 .hiddenStructure {
460493 display: none;
461494 speak: none;
@@ -610,7 +643,8 @@
611644 }
612645 /* this can be used in the content area to switch off
613646 special external link styling */
614 -#bodyContent .plainlinks a {
 647+#bodyContent .plainlinks a,
 648+#bodyContent *[dir="rtl"] a {
615649 background: none !important;
616650 padding: 0 !important;
617651 }

Status & tagging log