r13172 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r13171‎ | r13172 | r13173 >
Date:04:20, 6 March 2006
Author:lupin-wp
Status:old
Tags:
Comment:
whitespace
Modified paths:
  • /trunk/phase3/includes/DatabasePostgreSQL.php (modified) (history)
  • /trunk/phase3/includes/SpecialPreferences.php (modified) (history)
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)
  • /trunk/phase3/includes/ZhClient.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPreferences.php
@@ -656,7 +656,7 @@
657657
658658 # <FIXME>
659659 # Enotif
660 - if ($wgEnableEmail) {
 660+ if ($wgEnableEmail) {
661661 $wgOut->addHTML( '<fieldset><legend>' . wfMsg( 'email' ) . '</legend>' );
662662 $wgOut->addHTML(
663663 $emailauthenticated.
Index: trunk/phase3/includes/DatabasePostgreSQL.php
@@ -120,7 +120,7 @@
121121
122122 function fetchRow( $res ) {
123123 @$row = pg_fetch_array( $res );
124 - if( pg_last_error($this->mConn) ) {
 124+ if( pg_last_error($this->mConn) ) {
125125 wfDebugDieBacktrace( 'SQL error: ' . htmlspecialchars( pg_last_error($this->mConn) ) );
126126 }
127127 return $row;
Index: trunk/phase3/includes/ZhClient.php
@@ -119,7 +119,7 @@
120120 $i+=$len;
121121 }
122122 return $ret;
123 - }
 123+ }
124124 /**
125125 * Perform word segmentation
126126 *
Index: trunk/phase3/includes/SpecialUpload.php
@@ -620,9 +620,9 @@
621621 </tr>
622622 <tr>" );
623623
624 - if ( $licenseshtml != '' ) {
625 - global $wgStylePath;
626 - $wgOut->addHTML( "
 624+ if ( $licenseshtml != '' ) {
 625+ global $wgStylePath;
 626+ $wgOut->addHTML( "
627627 <td align='right'><label for='wpLicense'>$license:</label></td>
628628 <td align='left'>
629629 <script type='text/javascript' src=\"$wgStylePath/common/upload.js\"></script>
@@ -635,15 +635,15 @@
636636 </tr>
637637 <tr>
638638 ");
639 - }
 639+ }
640640
641 - if ( $wgUseCopyrightUpload ) {
642 - $filestatus = wfMsgHtml ( 'filestatus' );
643 - $copystatus = htmlspecialchars( $this->mUploadCopyStatus );
644 - $filesource = wfMsgHtml ( 'filesource' );
645 - $uploadsource = htmlspecialchars( $this->mUploadSource );
646 -
647 - $wgOut->addHTML( "
 641+ if ( $wgUseCopyrightUpload ) {
 642+ $filestatus = wfMsgHtml ( 'filestatus' );
 643+ $copystatus = htmlspecialchars( $this->mUploadCopyStatus );
 644+ $filesource = wfMsgHtml ( 'filesource' );
 645+ $uploadsource = htmlspecialchars( $this->mUploadSource );
 646+
 647+ $wgOut->addHTML( "
648648 <td align='right' nowrap='nowrap'><label for='wpUploadCopyStatus'>$filestatus:</label></td>
649649 <td><input tabindex='5' type='text' name='wpUploadCopyStatus' id='wpUploadCopyStatus' value=\"$copystatus\" size='40' /></td>
650650 </tr>
@@ -653,10 +653,10 @@
654654 </tr>
655655 <tr>
656656 ");
657 - }
 657+ }
658658
659659
660 - $wgOut->addHtml( "
 660+ $wgOut->addHtml( "
661661 <td></td>
662662 <td>
663663 <input tabindex='7' type='checkbox' name='wpWatchthis' id='wpWatchthis' $watchChecked value='true' />
@@ -677,8 +677,8 @@
678678 <td></td>
679679 <td align='left'>
680680 " );
681 - $wgOut->addWikiText( wfMsgForContent( 'edittools' ) );
682 - $wgOut->addHTML( "
 681+ $wgOut->addWikiText( wfMsgForContent( 'edittools' ) );
 682+ $wgOut->addHTML( "
683683 </td>
684684 </tr>
685685

Status & tagging log