r12985 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12984‎ | r12985 | r12986 >
Date:06:02, 9 February 2006
Author:vibber
Status:old
Tags:
Comment:
Move the text direction class from <html> to <body>, HTML doesn't allow class on <html>
(Wouldn't be needed if the MSIE developers would actually make attribute selectors work on attributes that I actually want to use...)
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/monobook/IE70Fixes.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/IE70Fixes.css
@@ -9,13 +9,13 @@
1010 height: 1%;
1111 }
1212
13 -html.rtl #column-one {
 13+.rtl #column-one {
1414 /* For some reason it tries to inherit the padding-top into every div,
1515 * and I can't figure out how to get it back off.
1616 */
1717 padding-top: 0;
1818 }
19 -html.rtl #column-one #p-navigation {
 19+.rtl #column-one #p-navigation {
2020 margin-top: 160px;
2121 }
2222
Index: trunk/phase3/skins/MonoBook.php
@@ -51,7 +51,7 @@
5252 wfSuppressWarnings();
5353
5454 ?><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
55 -<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php $this->text('lang') ?>" lang="<?php $this->text('lang') ?>" dir="<?php $this->text('dir') ?>" class="<?php $this->text('dir') ?>">
 55+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php $this->text('lang') ?>" lang="<?php $this->text('lang') ?>" dir="<?php $this->text('dir') ?>">
5656 <head>
5757 <meta http-equiv="Content-Type" content="<?php $this->text('mimetype') ?>; charset=<?php $this->text('charset') ?>" />
5858 <?php $this->html('headlinks') ?>
@@ -62,7 +62,7 @@
6363 <!--[if lt IE 5.5000]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE50Fixes.css";</style><![endif]-->
6464 <!--[if IE 5.5000]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE55Fixes.css";</style><![endif]-->
6565 <!--[if IE 6]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE60Fixes.css";</style><![endif]-->
66 - <!--[if IE 7]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE70Fixes.css";</style><![endif]-->
 66+ <!--[if IE 7]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE70Fixes.css?1";</style><![endif]-->
6767 <!--[if lt IE 7]><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath') ?>/common/IEFixes.js"></script>
6868 <meta http-equiv="imagetoolbar" content="no" /><![endif]-->
6969 <?php if($this->data['jsvarurl' ]) { ?>
@@ -85,7 +85,7 @@
8686 </head>
8787 <body <?php if($this->data['body_ondblclick']) { ?>ondblclick="<?php $this->text('body_ondblclick') ?>"<?php } ?>
8888 <?php if($this->data['body_onload' ]) { ?>onload="<?php $this->text('body_onload') ?>"<?php } ?>
89 -<?php if($this->data['nsclass' ]) { ?>class="<?php $this->text('nsclass') ?>"<?php } ?>>
 89+ class="<?php $this->text('nsclass') ?> <?php $this->text('dir') ?>">
9090 <div id="globalWrapper">
9191 <div id="column-content">
9292 <div id="content">

Status & tagging log