r12942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12941‎ | r12942 | r12943 >
Date:04:04, 3 February 2006
Author:vibber
Status:old
Tags:
Comment:
* (bug 4303) Add $wgFavicon to change the shorticon icon link from
the default /favicon.ico or disable it (if set to false)
Patch by nekocue
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -118,6 +118,7 @@
119119 $wgUploadDirectory = "{$IP}/upload";
120120 $wgHashedUploadDirectory = true;
121121 $wgLogo = "{$wgUploadPath}/wiki.png";
 122+$wgFavicon = '/favicon.ico';
122123 $wgMathPath = "{$wgUploadPath}/math";
123124 $wgMathDirectory = "{$wgUploadDirectory}/math";
124125 $wgTmpDirectory = "{$wgUploadDirectory}/tmp";
Index: trunk/phase3/includes/Skin.php
@@ -156,10 +156,14 @@
157157 }
158158
159159 function initPage( &$out ) {
 160+ global $wgFavicon;
 161+
160162 $fname = 'Skin::initPage';
161163 wfProfileIn( $fname );
162164
163 - $out->addLink( array( 'rel' => 'shortcut icon', 'href' => '/favicon.ico' ) );
 165+ if( false !== $wgFavicon ) {
 166+ $out->addLink( array( 'rel' => 'shortcut icon', 'href' => $wgFavicon ) );
 167+ }
164168
165169 $this->addMetadataLinks($out);
166170
Index: trunk/phase3/RELEASE-NOTES
@@ -589,6 +589,8 @@
590590 and seems to work ok with other bits. No longer including the IE
591591 workarounds JavaScript for IE 7 and above.
592592 * Fix extra namespace for Bulgarian
 593+* (bug 4303) Add $wgFavicon to change the shorticon icon link from
 594+ the default /favicon.ico or disable it (if set to false)
593595
594596
595597 === Caveats ===

Status & tagging log