r12923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12922‎ | r12923 | r12924 >
Date:04:10, 31 January 2006
Author:timstarling
Status:old
Tags:
Comment:
Feature karma: removing a useless feature that I recently committed.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/SpecialListusers.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -1852,26 +1852,6 @@
18531853 array_keys( $wgGroupPermissions ),
18541854 array( '*', 'user', 'autoconfirmed' ) );
18551855 }
1856 -
1857 - /**
1858 - * Return the set of groups which are not marked "invisible"
1859 - * @return array
1860 - * @static
1861 - */
1862 - function getVisibleGroups() {
1863 - global $wgGroupPermissions, $wgInvisibleGroups;
1864 - return array_diff( User::getAllGroups(), $wgInvisibleGroups );
1865 - }
1866 -
1867 - /**
1868 - * Determine if a given group name is a valid, visible group
1869 - * @param string name
1870 - * @return bool
1871 - */
1872 - function isVisibleGroup( $group ) {
1873 - global $wgGroupPermissions, $wgInvisibleGroups;
1874 - return isset( $wgGroupPermissions[$group] ) && !in_array( $group, $wgInvisibleGroups );
1875 - }
18761856 }
18771857
18781858 ?>
Index: trunk/phase3/includes/DefaultSettings.php
@@ -847,11 +847,6 @@
848848 # $wgGroupPermissions['developer']['siteadmin'] = true;
849849
850850 /**
851 - * List of groups which won't appear in Special:Listusers
852 - */
853 -$wgInvisibleGroups = array();
854 -
855 -/**
856851 * Set of available actions that can be restricted via Special:Protect
857852 * You probably shouldn't change this.
858853 */
Index: trunk/phase3/includes/SpecialListusers.php
@@ -89,7 +89,7 @@
9090 wfMsgHtml( 'groups-editgroup-name' ) . '<select name="group">';
9191
9292 // get group names
93 - $groups = User::getVisibleGroups();
 93+ $groups = User::getAllGroups();
9494
9595 // we want a default empty group
9696 $out.= '<option value=""></option>';
@@ -185,9 +185,7 @@
186186 'ListUsersPage::formatResult' );
187187 $groups = array();
188188 while( $row = $dbr->fetchObject( $result ) ) {
189 - if ( User::isVisibleGroup( $row->ug_group ) ) {
190 - $groups[] = User::getGroupName( $row->ug_group );
191 - }
 189+ $groups[] = User::getGroupName( $row->ug_group );
192190 }
193191 $dbr->freeResult( $result );
194192
Index: trunk/phase3/RELEASE-NOTES
@@ -341,7 +341,6 @@
342342 * (bug 3192): properly check 'limit' parameter on Special:Contributions
343343 * (bug 3187) watchlist text refer to unexistent "Stop watching" action
344344 * Add block link and a link to the block log to Special:Contributions
345 -* Added $wgInvisibleGroups, to hide groups from Special:Listusers
346345 * Add contributions link to block log items
347346
348347 Misc.:

Status & tagging log