r12593 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12592‎ | r12593 | r12594 >
Date:00:09, 11 January 2006
Author:vibber
Status:old
Tags:
Comment:
Revert namespacebanner feature:
* causes fatal error during database error reporting
* indirect keys won't show up in allmessages; check this for correctness and safety
* no release notes entry for new feature!
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -505,7 +505,6 @@
506506 'restorelink' => '$1 deleted edits',
507507 'feedlinks' => 'Feed:',
508508 'sitenotice' => '-', # the equivalent to wgSiteNotice
509 -'namespacebanner' => 'Namespacebanner',
510509
511510 # Short words for each namespace, by default used in the 'article' tab in monobook
512511 'nstab-main' => 'Article',
Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1367,18 +1367,6 @@
13681368 }
13691369 }
13701370 }
1371 -
1372 - # Namespacebanner
1373 - $key = wfMsg('namespacebanner') ;
1374 - $ns = $wgTitle->getNsText() . '-' ;
1375 - if ( $ns != "" ) {
1376 - $key .= str_replace ( '_' , '-' , $ns ) ;
1377 - }
1378 - $nsbanner = wfMsg ( $key ) ;
1379 - if ( $nsbanner != "<".$key.">" ) {
1380 - $notice .= '<div id="namespacebanner">' . $nsbanner . "</div>" ;
1381 - }
1382 -
13831371 wfProfileOut( $fname );
13841372 return $notice;
13851373 }

Status & tagging log