r12475 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12474‎ | r12475 | r12476 >
Date:13:24, 7 January 2006
Author:hashar
Status:old
Tags:
Comment:
Backport from HEAD:
Fix #4510: Barnes & Noble ISBN URL change
Modified paths:
  • /branches/REL1_5/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_5/phase3/languages/Language.php (modified) (history)
  • /branches/REL1_5/phase3/languages/LanguageCy.php (modified) (history)
  • /branches/REL1_5/phase3/languages/LanguageEt.php (modified) (history)
  • /branches/REL1_5/phase3/languages/LanguageHe.php (modified) (history)
  • /branches/REL1_5/phase3/languages/LanguageId.php (modified) (history)

Diff [purge]

Index: branches/REL1_5/phase3/RELEASE-NOTES
@@ -1008,8 +1008,8 @@
10091009 === Changes since 1.5.5 ===
10101010
10111011 * (bug 4258) When installing under IIS, $wgArticlePath = "$wgScript?title=$1" should be set
 1012+* (bug 4510) Correct Barnes & Noble bookstore URLs
10121013
1013 -
10141014 === Caveats ===
10151015
10161016 Some output, particularly involving user-supplied inline HTML, may not
Index: branches/REL1_5/phase3/languages/LanguageHe.php
@@ -49,7 +49,7 @@
5050 /* private */ $wgBookstoreListHe = array(
5151 "מיתוס" => "http://www.mitos.co.il/ ",
5252 "ibooks" => "http://www.ibooks.co.il/",
53 - "Barnes & Noble" => "http://shop.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1",
 53+ "Barnes & Noble" => "http://search.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1",
5454 "Amazon.com" => "http://www.amazon.com/exec/obidos/ISBN=$1"
5555 );
5656
Index: branches/REL1_5/phase3/languages/LanguageId.php
@@ -66,7 +66,7 @@
6767 //# Default (EN) Bookstores
6868 //"AddALL" => "http://www.addall.com/New/Partner.cgi?query=$1&type=ISBN",
6969 //"PriceSCAN" => "http://www.pricescan.com/books/bookDetail.asp?isbn=$1",
70 - //"Barnes & Noble" => "http://shop.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1",
 70+ //"Barnes & Noble" => "http://search.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1",
7171 //"Amazon.com" => "http://www.amazon.com/exec/obidos/ISBN=$1"
7272 ) + $wgBookstoreListEn;
7373
Index: branches/REL1_5/phase3/languages/LanguageEt.php
@@ -60,7 +60,7 @@
6161 "Raamatukoi" => "http://www.raamatukoi.ee/cgi-bin/index?valik=otsing&paring=$1",
6262 "AddALL" => "http://www.addall.com/New/Partner.cgi?query=$1&type=ISBN",
6363 "PriceSCAN" => "http://www.pricescan.com/books/bookDetail.asp?isbn=$1",
64 - "Barnes & Noble" => "http://shop.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1",
 64+ "Barnes & Noble" => "http://search.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1",
6565 "Amazon.com" => "http://www.amazon.com/exec/obidos/ISBN=$1"
6666 );
6767
Index: branches/REL1_5/phase3/languages/Language.php
@@ -148,7 +148,7 @@
149149 /* private */ $wgBookstoreListEn = array(
150150 'AddALL' => 'http://www.addall.com/New/Partner.cgi?query=$1&type=ISBN',
151151 'PriceSCAN' => 'http://www.pricescan.com/books/bookDetail.asp?isbn=$1',
152 - 'Barnes & Noble' => 'http://shop.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1',
 152+ 'Barnes & Noble' => 'http://search.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1',
153153 'Amazon.com' => 'http://www.amazon.com/exec/obidos/ISBN=$1'
154154 );
155155
Index: branches/REL1_5/phase3/languages/LanguageCy.php
@@ -40,7 +40,7 @@
4141 /* private */ $wgBookstoreListCy = array(
4242 "AddALL" => "http://www.addall.com/New/Partner.cgi?query=$1&type=ISBN",
4343 "PriceSCAN" => "http://www.pricescan.com/books/bookDetail.asp?isbn=$1",
44 - "Barnes & Noble" => "http://shop.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1",
 44+ "Barnes & Noble" => "http://search.barnesandnoble.com/bookSearch/isbnInquiry.asp?isbn=$1",
4545 "Amazon.com" => "http://www.amazon.com/exec/obidos/ISBN=$1",
4646 "Amazon.co.uk" => "http://www.amazon.co.uk/exec/obidos/ISBN=$1"
4747 );

Status & tagging log