r12343 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12342‎ | r12343 | r12344 >
Date:00:04, 2 January 2006
Author:timstarling
Status:old
Tags:
Comment:
explicit limits for subqueries, MySQL doesn't seem to be able to work this out
Modified paths:
  • /trunk/phase3/includes/SpecialWhatlinkshere.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialWhatlinkshere.php
@@ -113,9 +113,9 @@
114114 // with an is_template field in the output indicating which one the link
115115 // came from
116116 $sql = "(SELECT page_id,page_namespace, page_title, page_is_redirect, 1 as is_template " .
117 - "FROM page, templatelinks WHERE $tlCond $offsetCond) " .
 117+ "FROM page, templatelinks WHERE $tlCond $offsetCond $options) " .
118118 "UNION (SELECT page_id,page_namespace, page_title, page_is_redirect, 0 as is_template " .
119 - "FROM page, pagelinks WHERE $plCond $offsetCond) $options";
 119+ "FROM page, pagelinks WHERE $plCond $offsetCond $options) $options";
120120 $res = $dbr->query( $sql, $fname );
121121 $numRows = $dbr->numRows( $res );
122122

Status & tagging log