r12286 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12285‎ | r12286 | r12287 >
Date:17:15, 29 December 2005
Author:vibber
Status:old
Tags:
Comment:
* Fix for short_open_tag off again; please don't break this, guys
Modified paths:
  • /trunk/extensions/Review/Review.php (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DatabaseMysql.php (modified) (history)
  • /trunk/phase3/includes/ProfilerSimpleUDP.php (modified) (history)
  • /trunk/phase3/includes/Wiki.php (modified) (history)
  • /trunk/phase3/languages/LanguagePt.php (modified) (history)
  • /trunk/phase3/languages/LanguagePt_br.php (modified) (history)
  • /trunk/phase3/maintenance/fixSlaveDesync.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/fixSlaveDesync.php
@@ -1,4 +1,4 @@
2 -<?
 2+<?php
33
44 $wgUseRootUser = true;
55 require_once( 'commandLine.inc' );
Index: trunk/phase3/skins/MonoBook.php
@@ -64,20 +64,20 @@
6565 <!--[if IE]><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath') ?>/common/IEFixes.js"></script>
6666 <meta http-equiv="imagetoolbar" content="no" /><![endif]-->
6767 <?php if($this->data['jsvarurl' ]) { ?>
68 - <script type="<?= $this->text('jsmimetype') ?>" src="<?= $this->text('jsvarurl' ) ?>"><!-- site js --></script>
 68+ <script type="<?php echo $this->text('jsmimetype') ?>" src="<?php echo $this->text('jsvarurl' ) ?>"><!-- site js --></script>
6969 <?php } ?>
70 - <script type="<?= $this->text('jsmimetype') ?>" src="<?= $this->text('stylepath' ) ?>/common/wikibits.js"><!-- wikibits js --></script>
 70+ <script type="<?php echo $this->text('jsmimetype') ?>" src="<?php echo $this->text('stylepath' ) ?>/common/wikibits.js"><!-- wikibits js --></script>
7171 <?php if($this->data['pagecss' ]) { ?>
72 - <style type="text/css"><?= $this->html('pagecss' ) ?></style>
 72+ <style type="text/css"><?php echo $this->html('pagecss' ) ?></style>
7373 <?php }
7474 if($this->data['usercss' ]) { ?>
75 - <style type="text/css"><?= $this->html('usercss' ) ?></style>
 75+ <style type="text/css"><?php echo $this->html('usercss' ) ?></style>
7676 <?php }
7777 if($this->data['userjs' ]) { ?>
78 - <script type="<?php $this->text('jsmimetype') ?>" src="<?= $this->text('userjs' ) ?>"></script>
 78+ <script type="<?php $this->text('jsmimetype') ?>" src="<?php echo $this->text('userjs' ) ?>"></script>
7979 <?php }
8080 if($this->data['userjsprev']) { ?>
81 - <script type="<?php $this->text('jsmimetype') ?>"><?= $this->html('userjsprev') ?></script>
 81+ <script type="<?php $this->text('jsmimetype') ?>"><?php echo $this->html('userjsprev') ?></script>
8282 <?php }
8383 if($this->data['trackbackhtml']) print $this->data['trackbackhtml']; ?>
8484 </head>
@@ -109,8 +109,8 @@
110110 <h5><?php $this->msg('views') ?></h5>
111111 <ul>
112112 <?php foreach($this->data['content_actions'] as $key => $tab) { ?>
113 - <li id="ca-<?= htmlspecialchars($key) ?>"<?php
114 - if($tab['class']) { ?> class="<?= htmlspecialchars($tab['class']) ?>"<?php }
 113+ <li id="ca-<?php echo htmlspecialchars($key) ?>"<?php
 114+ if($tab['class']) { ?> class="<?php echo htmlspecialchars($tab['class']) ?>"<?php }
115115 ?>><a href="<?php echo htmlspecialchars($tab['href']) ?>"><?php
116116 echo htmlspecialchars($tab['text']) ?></a></li>
117117 <?php } ?>
@@ -143,9 +143,9 @@
144144 <div class='pBody'>
145145 <ul>
146146 <?php foreach($cont as $key => $val) { ?>
147 - <li id="<?= htmlspecialchars($val['id']) ?>"<?php
 147+ <li id="<?php echo htmlspecialchars($val['id']) ?>"<?php
148148 if ( $val['active'] ) { ?> class="active" <?php }
149 - ?>><a href="<?= htmlspecialchars($val['href']) ?>"><?= htmlspecialchars($val['text']) ?></a></li>
 149+ ?>><a href="<?php echo htmlspecialchars($val['href']) ?>"><?php echo htmlspecialchars($val['text']) ?></a></li>
150150 <?php } ?>
151151 </ul>
152152 </div>
@@ -173,12 +173,12 @@
174174 if($this->data['notspecialpage']) { ?>
175175 <li id="t-whatlinkshere"><a href="<?php
176176 echo htmlspecialchars($this->data['nav_urls']['whatlinkshere']['href'])
177 - ?>"><?= $this->msg('whatlinkshere') ?></a></li>
 177+ ?>"><?php echo $this->msg('whatlinkshere') ?></a></li>
178178 <?php
179179 if( $this->data['nav_urls']['recentchangeslinked'] ) { ?>
180180 <li id="t-recentchangeslinked"><a href="<?php
181181 echo htmlspecialchars($this->data['nav_urls']['recentchangeslinked']['href'])
182 - ?>"><?= $this->msg('recentchangeslinked') ?></a></li>
 182+ ?>"><?php echo $this->msg('recentchangeslinked') ?></a></li>
183183 <?php }
184184 }
185185 if(isset($this->data['nav_urls']['trackbacklink'])) { ?>
@@ -188,29 +188,29 @@
189189 <?php }
190190 if($this->data['feeds']) { ?>
191191 <li id="feedlinks"><?php foreach($this->data['feeds'] as $key => $feed) {
192 - ?><span id="feed-<?= htmlspecialchars($key) ?>"><a href="<?php
193 - echo htmlspecialchars($feed['href']) ?>"><?= htmlspecialchars($feed['text'])?></a>&nbsp;</span>
 192+ ?><span id="feed-<?php echo htmlspecialchars($key) ?>"><a href="<?php
 193+ echo htmlspecialchars($feed['href']) ?>"><?php echo htmlspecialchars($feed['text'])?></a>&nbsp;</span>
194194 <?php } ?></li><?php
195195 }
196196
197197 foreach( array('contributions', 'blockip', 'emailuser', 'upload', 'specialpages') as $special ) {
198198
199199 if($this->data['nav_urls'][$special]) {
200 - ?><li id="t-<?= $special ?>"><a href="<?= htmlspecialchars($this->data['nav_urls'][$special]['href'])
 200+ ?><li id="t-<?php echo $special ?>"><a href="<?php echo htmlspecialchars($this->data['nav_urls'][$special]['href'])
201201 ?>"><?php $this->msg($special) ?></a></li>
202202 <?php }
203203 }
204204
205205 if(!empty($this->data['nav_urls']['print']['href'])) { ?>
206 - <li id="t-print"><a href="<?= htmlspecialchars($this->data['nav_urls']['print']['href'])
207 - ?>"><?= $this->msg('printableversion') ?></a></li><?php
 206+ <li id="t-print"><a href="<?php echo htmlspecialchars($this->data['nav_urls']['print']['href'])
 207+ ?>"><?php echo $this->msg('printableversion') ?></a></li><?php
208208 }
209209
210210 if(!empty($this->data['nav_urls']['permalink']['href'])) { ?>
211 - <li id="t-permalink"><a href="<?= htmlspecialchars($this->data['nav_urls']['permalink']['href'])
212 - ?>"><?= $this->msg('permalink') ?></a></li><?php
 211+ <li id="t-permalink"><a href="<?php echo htmlspecialchars($this->data['nav_urls']['permalink']['href'])
 212+ ?>"><?php echo $this->msg('permalink') ?></a></li><?php
213213 } elseif ($this->data['nav_urls']['permalink']['href'] === '') { ?>
214 - <li id="t-ispermalink"><?= $this->msg('permalink') ?></li><?php
 214+ <li id="t-ispermalink"><?php echo $this->msg('permalink') ?></li><?php
215215 }
216216
217217 wfRunHooks( 'MonoBookTemplateToolboxEnd', array( &$this ) );
@@ -221,12 +221,12 @@
222222 <?php
223223 if( $this->data['language_urls'] ) { ?>
224224 <div id="p-lang" class="portlet">
225 - <h5><?= $this->msg('otherlanguages') ?></h5>
 225+ <h5><?php echo $this->msg('otherlanguages') ?></h5>
226226 <div class="pBody">
227227 <ul>
228228 <?php foreach($this->data['language_urls'] as $langlink) { ?>
229 - <li class="<?= htmlspecialchars($langlink['class'])?>"><?php
230 - ?><a href="<?= htmlspecialchars($langlink['href']) ?>"><?= $langlink['text'] ?></a></li>
 229+ <li class="<?php echo htmlspecialchars($langlink['class'])?>"><?php
 230+ ?><a href="<?php echo htmlspecialchars($langlink['href']) ?>"><?php echo $langlink['text'] ?></a></li>
231231 <?php } ?>
232232 </ul>
233233 </div>
@@ -253,7 +253,7 @@
254254 );
255255 foreach( $footerlinks as $aLink ) {
256256 if( $this->data[$aLink] ) {
257 -?> <li id="<?=$aLink?>"><?= $this->html($aLink) ?></li>
 257+?> <li id="<?php echo$aLink?>"><?php echo $this->html($aLink) ?></li>
258258 <?php }
259259 }
260260 ?>
@@ -261,7 +261,7 @@
262262 </div>
263263 <script type="text/javascript"> if (window.runOnloadHook) runOnloadHook();</script>
264264 </div>
265 -<?= $this->html('reporttime') ?>
 265+<?php echo $this->html('reporttime') ?>
266266
267267 </body></html>
268268 <?php
Index: trunk/phase3/includes/Wiki.php
@@ -1,4 +1,4 @@
2 -<?
 2+<?php
33
44 #__________________________
55 #wiki class
Index: trunk/phase3/includes/ProfilerSimpleUDP.php
@@ -1,4 +1,4 @@
2 -<?
 2+<?php
33 /* ProfilerSimpleUDP class, that sends out messages for 'udpprofile' daemon
44 (the one from wikipedia/udpprofile CVS )
55 */
Index: trunk/phase3/includes/DatabaseMysql.php
@@ -1,4 +1,4 @@
2 -<?
 2+<?php
33 /*
44 * Stub database class for MySQL.
55 */
Index: trunk/phase3/RELEASE-NOTES
@@ -370,6 +370,7 @@
371371 * (bug 2726, 3397) Fix [[Special:]] and [[:Image]] links in action=render
372372 * (bug 3794) Include OS / platform info in Special:Version
373373 * (bug 4419) Remove obsolete magnify.png.old
 374+* Fix for short_open_tag off again; please don't break this, guys
374375
375376
376377 === Caveats ===
Index: trunk/phase3/languages/LanguagePt.php
@@ -1,4 +1,4 @@
2 -<?
 2+<?php
33 /** Portuguese (Português)
44 * This translation was made by:
55 * - Yves Marques Junqueira
Index: trunk/phase3/languages/LanguagePt_br.php
@@ -1,4 +1,4 @@
2 -<?PHP
 2+<?php
33 /** Brazilian Portugese (Portuguêsi do Brasil)
44 * @package MediaWiki
55 * @subpackage Language
Index: trunk/extensions/Review/Review.php
@@ -1,4 +1,4 @@
2 -<?
 2+<?php
33 /**
44 * An extension that let your users review article quality.
55 *

Status & tagging log