r122 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r121‎ | r122 | r123 >
Date:15:58, 11 February 2002
Author:hidders
Status:old
Tags:
Comment:
some extra schema changes, commented all commands out
Modified paths:
  • /trunk/phpwiki/fpw/updSchema.sql (modified) (history)
  • /trunk/phpwiki/fpw/wikipedia.sql (modified) (history)

Diff [purge]

Index: trunk/phpwiki/fpw/wikipedia.sql
@@ -24,9 +24,8 @@
2525 cur_unlinked_links mediumtext,
2626 cur_counter bigint(20) unsigned default '0',
2727 cur_cache mediumtext,
28 - UNIQUE KEY cur_id (cur_id),
2928 UNIQUE KEY cur_title (cur_title),
30 - KEY cur_id_2 (cur_id),
 29+ UNIQUE KEY cur_id (cur_id),
3130 KEY timeind (cur_timestamp)
3231 ) TYPE=ISAM PACK_KEYS=1;
3332
@@ -36,7 +35,7 @@
3736
3837 CREATE TABLE old (
3938 old_id mediumint(8) unsigned NOT NULL auto_increment,
40 - old_title varchar(255) binary default NULL,
 39+ old_title varchar(255) binary NOT NULL default '',
4140 old_text mediumtext,
4241 old_comment tinyblob,
4342 old_user mediumint(8) unsigned default '0',
@@ -44,10 +43,9 @@
4544 old_old_version mediumint(8) unsigned default '0',
4645 old_timestamp timestamp(14) NOT NULL,
4746 old_minor_edit tinyint(1) default '0',
48 - PRIMARY KEY (old_id),
4947 UNIQUE KEY old_id (old_id),
50 - KEY old_id_2 (old_id),
51 - KEY timeind (old_timestamp)
 48+ KEY timeind (old_timestamp),
 49+ KEY old_title (old_title)
5250 ) TYPE=ISAM PACK_KEYS=1;
5351
5452 #
@@ -62,8 +60,6 @@
6361 user_email tinytext,
6462 user_options mediumtext,
6563 user_watch mediumtext,
66 - PRIMARY KEY (user_id),
67 - UNIQUE KEY user_id (user_id),
68 - KEY user_id_2 (user_id)
 64+ UNIQUE KEY user_id (user_id)
6965 ) TYPE=ISAM PACK_KEYS=1;
7066
Index: trunk/phpwiki/fpw/updSchema.sql
@@ -1,18 +1,23 @@
22 # This code adapts older versions of the database.
33 # It adapts the table definitions adds indexes and, if necessary,
4 -# fills new columns with appropriate values.
 4+# fills new columns with appropriate values. Uncomment
 5+# the command that you still need to run to bring
 6+# your database scheme up-to-date.
57
68 # adding the indexes on the timestamps
79
8 -ALTER TABLE cur ADD INDEX timeind (cur_timestamp);
9 -ALTER TABLE old ADD INDEX timeind (old_timestamp);
 10+# ALTER TABLE cur ADD INDEX timeind (cur_timestamp);
 11+# ALTER TABLE old ADD INDEX timeind (old_timestamp);
1012
1113 # adding index on old_title
1214
13 -ALTER TABLE old MODIFY old_title VARCHAR(255) BINARY NOT NULL DEFAULT '';
14 -ALTER TABLE old ADD INDEX old_title (old_title);
 15+# ALTER TABLE old MODIFY old_title VARCHAR(255) BINARY NOT NULL DEFAULT '';
 16+# ALTER TABLE old ADD INDEX old_title (old_title);
1517
16 -# dropping the superfluous indexes on cur_id and old_id
 18+# dropping the superfluous indexes
1719
18 -ALTER TABLE cur DROP key cur_id_2;
19 -ALTER TABLE old DROP key old_id_2;
 20+# ALTER TABLE cur DROP KEY cur_id_2;
 21+# ALTER TABLE old DROP KEY old_id_2;
 22+# ALTER TABLE old DROP PRIMARY KEY;
 23+# ALTER TABLE user DROP PRIMARY KEY;
 24+# ALTER TABLE user DROP KEY user_id_2;

Status & tagging log