r12184 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12183‎ | r12184 | r12185 >
Date:02:47, 21 December 2005
Author:avar
Status:old
Tags:
Comment:
* (bug 1572) add a "diff penultimate revision" link to msg:newmessages
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -280,7 +280,12 @@
281281 $ntl = wfMsg( 'newmessages',
282282 $this->makeKnownLinkObj(
283283 $usertalktitle,
284 - wfMsg('newmessageslink')
 284+ wfMsgHtml( 'newmessageslink' )
 285+ ),
 286+ $this->makeKnownLinkObj(
 287+ $usertalktitle,
 288+ wfMsgHtml( 'newmessagesdifflink' ),
 289+ 'diff=cur'
285290 )
286291 );
287292 # Disable Cache
Index: trunk/phase3/includes/Skin.php
@@ -623,13 +623,12 @@
624624 }
625625
626626 if ( $wgUser->getNewtalk() ) {
627 - # do not show "You have new messages" text when we are viewing our
628 - # own talk page
629 -
 627+ # do not show "You have new messages" text when we are viewing our
 628+ # own talk page
630629 if( !$wgTitle->equals( $wgUser->getTalkPage() ) ) {
631 - $tl = $this->makeKnownLinkObj( $wgUser->getTalkPage(),
632 - wfMsg('newmessageslink') );
633 - $s.= ' | <strong>'. wfMsg( 'newmessages', $tl ) . '</strong>';
 630+ $tl = $this->makeKnownLinkObj( $wgUser->getTalkPage(), wfMsgHtml( 'newmessageslink' ) );
 631+ $dl = $this->makeKnownLinkObj( $wgUser->getTalkPage(), wfMsgHtml( 'newmessagesdifflink' ) );
 632+ $s.= ' | <strong>'. wfMsg( 'newmessages', $tl, $dl ) . '</strong>';
634633 # disable caching
635634 $wgOut->setSquidMaxage(0);
636635 $wgOut->enableClientCache(false);
Index: trunk/phase3/languages/Language.php
@@ -495,8 +495,9 @@
496496 'pagetitle' => '$1 - {{SITENAME}}',
497497 'sitesubtitle' => '',
498498 'retrievedfrom' => 'Retrieved from "$1"',
499 -'newmessages' => 'You have $1.',
 499+'newmessages' => 'You have $1 ($2).',
500500 'newmessageslink' => 'new messages',
 501+'newmessagesdifflink' => 'diff to penultimate revision',
501502 'editsection'=>'edit',
502503 'toc' => 'Contents',
503504 'showtoc' => 'show',

Status & tagging log