r12050 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r12049‎ | r12050 | r12051 >
Date:02:46, 11 December 2005
Author:vibber
Status:old
Tags:
Comment:
Avar poked in these hooks as a demo for Tom, but they aren't probably
a good way to do it. Better probably would be manipulating the
set of special pages, which already have a spot for requiring
a permission key.
Modified paths:
  • /trunk/phase3/includes/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/SpecialListusers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialContributions.php
@@ -216,9 +216,6 @@
217217
218218 $id = User::idFromName($nt->getText());
219219
220 - if ( ! wfRunHooks( 'wfSpecialContributionsAfterId', array( &$this, &$id ) ) )
221 - return;
222 -
223220 if ( 0 == $id ) {
224221 $ul = $nt->getText();
225222 } else {
Index: trunk/phase3/includes/SpecialListusers.php
@@ -209,11 +209,8 @@
210210 * $par string (optional) A group to list users from
211211 */
212212 function wfSpecialListusers( $par = null ) {
213 - if ( ! wfRunHooks( 'wfSpecialListusers' ) )
214 - return;
215 -
216213 global $wgRequest;
217 -
 214+
218215 list( $limit, $offset ) = wfCheckLimits();
219216
220217

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r12031* (bug 3294) A hook intended for use by extensions/Contributionsviewpermissio...avar09:50, 9 December 2005

Status & tagging log