r11998 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11997‎ | r11998 | r11999 >
Date:22:33, 6 December 2005
Author:jeluf
Status:old
Tags:
Comment:
Avoid FATAL ERROR when creating thumbnail of non-existing image
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -480,6 +480,8 @@
481481 if ( $img->exists() ) {
482482 $width = $img->getWidth();
483483 $height = $img->getHeight();
 484+ } else {
 485+ return $this->makeBrokenLinkObj( $img->getTitle() );
484486 }
485487 if ( 0 == $width || 0 == $height ) {
486488 $width = $height = 200;
Index: trunk/phase3/RELEASE-NOTES
@@ -299,6 +299,7 @@
300300 get a blue link even if there's no local description page
301301 * (bug 4169) Use $wgLegalTitleChars in pipe trick conversions
302302 * (bug 4170) Decode HTML character escapes in sort key
 303+* Avoid FATAL ERROR when creating thumbnail of non-existing image
303304
304305
305306 === Caveats ===

Status & tagging log