r11991 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11990‎ | r11991 | r11992 >
Date:13:29, 6 December 2005
Author:timstarling
Status:old
Tags:
Comment:
Lazy initialisation of wgProxyList
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -374,7 +374,7 @@
375375 * master.
376376 */
377377 function getBlockedStatus( $bFromSlave = true ) {
378 - global $wgProxyList, $wgEnableSorbs, $wgProxyWhitelist;
 378+ global $wgEnableSorbs, $wgProxyWhitelist;
379379
380380 if ( -1 != $this->mBlockedby ) {
381381 wfDebug( "User::getBlockedStatus: already loaded.\n" );
@@ -406,7 +406,7 @@
407407 if ( !$this->isSysop() && !in_array( $ip, $wgProxyWhitelist ) ) {
408408
409409 # Local list
410 - if ( array_key_exists( $ip, $wgProxyList ) ) {
 410+ if ( wfIsLocallyBlockedProxy( $ip ) ) {
411411 $this->mBlockedby = wfMsg( 'proxyblocker' );
412412 $this->mBlockreason = wfMsg( 'proxyblockreason' );
413413 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r44243Updated $wgProxyList doc, removed "(in the keys)" since it can also be in the...ialex21:26, 4 December 2008

Status & tagging log