r11986 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11985‎ | r11986 | r11987 >
Date:01:32, 6 December 2005
Author:avar
Status:old
Tags:
Comment:
* (bug http://en.wikipedia.org/w/index.php?title=User_talk:%C3%86var_Arnfj%C3%B6r%C3%B0_Bjarmason&oldid=30287439#Save_button_problem_in_preferences)
use a proper title="" for the save button in the preferences, for accessability with screen readers
Modified paths:
  • /trunk/phase3/includes/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPreferences.php
@@ -871,9 +871,9 @@
872872 $wgOut->addHTML( "
873873 <div id='prefsubmit'>
874874 <div>
875 - <input type='submit' name='wpSaveprefs' class='btnSavePrefs' value=\"" . wfMsg( 'saveprefs' ) . "\" accesskey=\"".
876 - wfMsg('accesskey-save')."\" title=\"[alt-".wfMsg('accesskey-save')."]\" />
877 - <input type='submit' name='wpReset' value=\"" . wfMsg( 'resetprefs' ) . "\" />
 875+ <input type='submit' name='wpSaveprefs' class='btnSavePrefs' value=\"" . wfMsgHtml( 'saveprefs' ) . "\" accesskey=\"".
 876+ wfMsgHtml('accesskey-save')."\" title=\"".wfMsgHtml('tooltip-save')."\" />
 877+ <input type='submit' name='wpReset' value=\"" . wfMsgHtml( 'resetprefs' ) . "\" />
878878 </div>
879879
880880 </div>

Status & tagging log