r11977 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11976‎ | r11977 | r11978 >
Date:07:44, 5 December 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 4169) Use $wgLegalTitleChars in pipe trick conversions
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Parser.php
@@ -3120,8 +3120,10 @@
31213121
31223122 # Context links: [[|name]] and [[name (context)|]]
31233123 #
3124 - $tc = "[&;%\\-,.\\(\\)' _0-9A-Za-z\\/:\\x80-\\xff]";
3125 - $np = "[&;%\\-,.' _0-9A-Za-z\\/:\\x80-\\xff]"; # No parens
 3124+ global $wgLegalTitleChars;
 3125+ $tc = "[$wgLegalTitleChars]";
 3126+ $np = str_replace( array( '(', ')' ), array( '', '' ), $tc ); # No parens
 3127+
31263128 $namespacechar = '[ _0-9A-Za-z\x80-\xff]'; # Namespaces can use non-ascii!
31273129 $conpat = "/^({$np}+) \\(({$tc}+)\\)$/";
31283130
Index: trunk/phase3/RELEASE-NOTES
@@ -297,6 +297,7 @@
298298 * (bug 4167) Fix regression caused by patch for bug 153
299299 * (bug 1850) Additional fixes so existing local and remote images
300300 get a blue link even if there's no local description page
 301+* (bug 4169) Use $wgLegalTitleChars in pipe trick conversions
301302
302303
303304 === Caveats ===

Status & tagging log