r11972 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11971‎ | r11972 | r11973 >
Date:02:20, 5 December 2005
Author:vibber
Status:old
Tags:
Comment:
Don't disappear a parameter in a derived class just because you don't use it; that's unclean and poor practice
Modified paths:
  • /trunk/phase3/includes/WebRequest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WebRequest.php
@@ -458,7 +458,7 @@
459459 wfDebugDieBacktrace( 'FauxRequest::getRequestURL() not implemented' );
460460 }
461461
462 - function appendQuery( ) {
 462+ function appendQuery( $query ) {
463463 wfDebugDieBacktrace( 'FauxRequest::appendQuery() not implemented' );
464464 }
465465

Status & tagging log