r11968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11967‎ | r11968 | r11969 >
Date:20:56, 4 December 2005
Author:hashar
Status:old
Tags:
Comment:
unused dbw , remove call by reference but put a comment
Modified paths:
  • /trunk/phase3/includes/QueryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/QueryPage.php
@@ -263,7 +263,6 @@
264264 $fname = get_class($this) . '::doQuery';
265265 $sql = $this->getSQL();
266266 $dbr =& wfGetDB( DB_SLAVE );
267 - $dbw =& wfGetDB( DB_MASTER );
268267 $querycache = $dbr->tableName( 'querycache' );
269268
270269 $wgOut->setSyndicated( $this->isSyndicated() );
@@ -338,9 +337,10 @@
339338 }
340339
341340 /**
342 - * Do any necessary preprocessing of the result object
 341+ * Do any necessary preprocessing of the result object.
 342+ * You should pass this by reference: &$db , &$res
343343 */
344 - function preprocessResults( &$db, &$res ) {}
 344+ function preprocessResults( $db, $res ) {}
345345
346346 /**
347347 * Similar to above, but packaging in a syndicated feed instead of a web page

Status & tagging log