r11939 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11938‎ | r11939 | r11940 >
Date:00:56, 4 December 2005
Author:hashar
Status:old
Tags:
Comment:
some accessibility, source formatting
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -63,10 +63,10 @@
6464 <!--[if gte IE 6]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE60Fixes.css";</style><![endif]-->
6565 <!--[if IE]><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath') ?>/common/IEFixes.js"></script>
6666 <meta http-equiv="imagetoolbar" content="no" /><![endif]-->
67 - <?php if($this->data['jsvarurl' ]) { ?><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('jsvarurl' ) ?>"></script><?php } ?>
68 - <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath' ) ?>/common/wikibits.js"></script>
69 - <?php if($this->data['pagecss' ]) { ?><style type="text/css"><?php $this->html('pagecss' ) ?></style><?php } ?>
70 - <?php if($this->data['usercss' ]) { ?><style type="text/css"><?php $this->html('usercss' ) ?></style><?php } ?>
 67+ <?php if($this->data['jsvarurl' ]) { ?><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('jsvarurl' ) ?>"><!-- site js --></script><?php } ?>
 68+ <script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('stylepath' ) ?>/common/wikibits.js"><!-- wikibits js --></script>
 69+ <?php if($this->data['pagecss' ]) { ?><style type="text/css"><?php $this->html('pagecss' ) ?></style><?php } ?>
 70+ <?php if($this->data['usercss' ]) { ?><style type="text/css"><?php $this->html('usercss' ) ?></style><?php } ?>
7171 <?php if($this->data['userjs' ]) { ?><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text('userjs' ) ?>"></script><?php } ?>
7272 <?php if($this->data['userjsprev']) { ?><script type="<?php $this->text('jsmimetype') ?>"><?php $this->html('userjsprev') ?></script><?php } ?>
7373 <?php if($this->data['trackbackhtml']) print $this->data['trackbackhtml']; ?>
@@ -146,16 +146,13 @@
147147 <h5><label for="searchInput"><?php $this->msg('search') ?></label></h5>
148148 <div class="pBody">
149149 <form action="<?php $this->text('searchaction') ?>" id="searchform"><div>
150 - <input id="searchInput" name="search" type="text"
151 - <?php if($this->haveMsg('accesskey-search')) {
 150+ <input id="searchInput" name="search" type="text" <?php
 151+ if($this->haveMsg('accesskey-search')) {
152152 ?>accesskey="<?php $this->msg('accesskey-search') ?>"<?php }
153153 if( isset( $this->data['search'] ) ) {
154154 ?> value="<?php $this->text('search') ?>"<?php } ?> />
155 - <input type='submit' name="go" class="searchButton" id="searchGoButton"
156 - value="<?php $this->msg('go') ?>"
157 - />&nbsp;<input type='submit' name="fulltext"
158 - class="searchButton"
159 - value="<?php $this->msg('search') ?>" />
 155+ <input type='submit' name="go" class="searchButton" id="searchGoButton" value="<?php $this->msg('go') ?>" />&nbsp;
 156+ <input type='submit' name="fulltext" class="searchButton" value="<?php $this->msg('search') ?>" />
160157 </div></form>
161158 </div>
162159 </div>
@@ -229,7 +226,7 @@
230227 <?php if($this->data['tagline']) { ?><li id="f-tagline"><?php echo $this->data['tagline'] ?></li><?php } ?>
231228 </ul>
232229 </div>
233 - <script type="text/javascript"> if (window.runOnloadHook) runOnloadHook(); </script>
 230+ <script type="text/javascript"> if (window.runOnloadHook) runOnloadHook();</script>
234231 </div>
235232 <?php $this->html('reporttime') ?>
236233 </body>

Status & tagging log