r11924 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11923‎ | r11924 | r11925 >
Date:16:51, 3 December 2005
Author:hashar
Status:old
Tags:
Comment:
Fix validation issue with Special:Userlogin , the div and the form shared
the same id / name wich is invalid. Form element is now named userloginForm
Modified paths:
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -1065,7 +1065,7 @@
10661066 margin-top: 2em;
10671067 }
10681068
1069 -#userlogin {
 1069+#userloginForm {
10701070 margin: 0 3em 1em 0;
10711071 border: 1px solid #aaa;
10721072 clear: both;
@@ -1074,11 +1074,11 @@
10751075 float: left;
10761076 }
10771077
1078 -#userlogin table {
 1078+#userloginForm table {
10791079 background-color: #f9f9f9;
10801080 }
10811081
1082 -#userlogin h2 {
 1082+#userloginForm h2 {
10831083 padding-top: 0;
10841084 }
10851085
@@ -1400,4 +1400,4 @@
14011401 background: #fff;
14021402 padding: .2em 1em;
14031403 color: #000;
1404 -}
\ No newline at end of file
 1404+}
Index: trunk/phase3/includes/templates/Userlogin.php
@@ -26,7 +26,7 @@
2727 <div class="visualClear"></div>
2828 <?php } ?>
2929
30 -<div id="userlogin">
 30+<div id="userloginForm">
3131 <form name="userlogin" method="post" action="<?php $this->text('action') ?>">
3232 <h2><?php $this->msg('login') ?></h2>
3333 <p id="userloginlink"><?php $this->html('link') ?></p>

Status & tagging log