r114936 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114935‎ | r114936 | r114937 >
Date:12:50, 17 April 2012
Author:netbrain
Status:new
Tags:
Comment:
changed some cosmetics

changed "edit" link text to "edit menu"
added css class to edit menu link so style can be overridden
added default css style to edit menu link font-size:smaller;
Modified paths:
  • /trunk/extensions/SideBarMenu/SideBarMenu.hooks.php (modified) (history)
  • /trunk/extensions/SideBarMenu/SideBarMenu.i18n.php (modified) (history)
  • /trunk/extensions/SideBarMenu/css/ext.sidebarmenu.css (modified) (history)

Diff [purge]

Index: trunk/extensions/SideBarMenu/SideBarMenu.i18n.php
@@ -17,7 +17,7 @@
1818 'sidebarmenu-parser-syntax-error' => 'Could not parse "$1", make sure the syntax is correct.',
1919 'sidebarmenu-js-init-error' => 'Failed loading JavaScript resources.',
2020 'sidebarmenu-parser-menuitem-expanded-null' => '"parser.menuitem.expanded" should be true or false, instead it is null.',
21 - 'sidebarmenu-edit' => 'Edit'
 21+ 'sidebarmenu-edit' => 'Edit menu'
2222 );
2323
2424 /** Message documentation (Message documentation)
Index: trunk/extensions/SideBarMenu/SideBarMenu.hooks.php
@@ -22,7 +22,7 @@
2323 return wfMsg('sidebarmenu-parser-input-error', $x->getMessage());
2424 }
2525 if ($config[SBM_EDIT_LINK]) {
26 - $output .= Linker::link($frame->getTitle(), wfMsg('sidebarmenu-edit'), array('title' => wfMsg('sidebarmenu-edit')), array('action' => 'edit'));
 26+ $output .= Linker::link($frame->getTitle(), wfMsg('sidebarmenu-edit'), array('title' => wfMsg('sidebarmenu-edit'),'class' => 'sidebar-menu-edit-link'), array('action' => 'edit'));
2727 }
2828 $output .= '</div>';
2929
Index: trunk/extensions/SideBarMenu/css/ext.sidebarmenu.css
@@ -63,3 +63,7 @@
6464 user-select: none;
6565 }
6666
 67+.sidebar-menu-edit-link {
 68+ font-size: smaller;
 69+}
 70+