r114934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114933‎ | r114934 | r114935 >
Date:22:13, 16 April 2012
Author:awjrichards
Status:deferred
Tags:
Comment:
MFG Change-Id: I92ca039541c6956a48a6600150ae16b367f278c5
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/MobileFrontend/templates/ApplicationTemplate.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/MobileFrontend/templates/ApplicationTemplate.php
@@ -29,11 +29,11 @@
3030 $noticeHtml = ( isset( $this->data['noticeHtml'] ) ) ? $this->data['noticeHtml'] : '';
3131
3232 $startScriptTag = '<script type="text/javascript" src="';
33 - $endScriptTag = '"></script>';
 33+ $endScriptTag = "?version={$wgMobileResourceVersion}\"></script>";
3434 $javaScriptPath = $this->data['wgExtensionAssetsPath'] . '/MobileFrontend/javascripts/';
3535
3636 $jQuerySupport = $this->data['device']['supports_jquery'];
37 - $jQueryScript = $jQuerySupport ? $startScriptTag . $javaScriptPath . 'jquery-1.7.2.min.js' . $endScriptTag : '';
 37+ $jQueryScript = $jQuerySupport ? "{$startScriptTag}{$javaScriptPath}jquery-1.7.2.min.js{$endScriptTag}" : '';
3838 $filePageScript = ( $this->data['isFilePage'] ) ? $startScriptTag . $javaScriptPath . 'filepage.js?version=' . $wgMobileResourceVersion . $endScriptTag : '';
3939
4040 $robots = isset( $this->data['robots'] ) ? "\n {$this->data['robots']}" : '';
@@ -64,7 +64,7 @@
6565
6666 if( $this->data['isBetaGroupMember'] && $jQuerySupport ) {
6767 $betajs = <<<HTML
68 - {$startScriptTag}{$javaScriptPath}references.{$resourceSuffix}js?version={$wgMobileResourceVersion}{$endScriptTag}
 68+ {$startScriptTag}{$javaScriptPath}references.{$resourceSuffix}js{$endScriptTag}
6969 HTML;
7070 } else {
7171 $betajs = "";
@@ -95,10 +95,10 @@
9696 </div>
9797 {$this->data['footerHtml']}
9898 <!--[if gt IE 9]><!-->
99 - {$startScriptTag}{$javaScriptPath}application.{$resourceSuffix}js?version={$wgMobileResourceVersion}{$endScriptTag}
100 - {$startScriptTag}{$javaScriptPath}toggle.{$resourceSuffix}js?version={$wgMobileResourceVersion}{$endScriptTag}
101 - {$startScriptTag}{$javaScriptPath}banner.{$resourceSuffix}js?version={$wgMobileResourceVersion}{$endScriptTag}
102 - {$startScriptTag}{$javaScriptPath}{$betaPrefix}opensearch.{$resourceSuffix}js?version={$wgMobileResourceVersion}{$endScriptTag}
 99+ {$startScriptTag}{$javaScriptPath}application.{$resourceSuffix}js{$endScriptTag}
 100+ {$startScriptTag}{$javaScriptPath}toggle.{$resourceSuffix}js{$endScriptTag}
 101+ {$startScriptTag}{$javaScriptPath}banner.{$resourceSuffix}js{$endScriptTag}
 102+ {$startScriptTag}{$javaScriptPath}{$betaPrefix}opensearch.{$resourceSuffix}js{$endScriptTag}
103103 {$betajs}
104104 {$filePageScript}
105105 <!--[endif]-->

Status & tagging log