r114423 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114422‎ | r114423 | r114424 >
Date:14:37, 22 March 2012
Author:rsterbin
Status:deferred
Tags:missed-git-conversion 
Comment:
Bump up version numbers; make no-link option explicit
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php
@@ -90,7 +90,7 @@
9191 // This version number is added to all tracking event names, so that
9292 // changes in the software don't corrupt the data being collected. Bump
9393 // this when you want to start a new "experiment".
94 - 'version' => 0,
 94+ 'version' => 1,
9595 // Let users be tracked for a month, and then rebucket them, allowing some
9696 // churn.
9797 'expires' => 30,
@@ -113,7 +113,7 @@
114114 ),
115115 // This version number is added to all tracking event names, so that changes in the software
116116 // don't corrupt the data being collected. Bump this when you want to start a new "experiment".
117 - 'version' => 0,
 117+ 'version' => 1,
118118 // Let users be tracked for a month, and then rebucket them, allowing some churn
119119 'expires' => 30,
120120 // Track the event of users being bucketed - so we can be sure the odds
@@ -135,7 +135,7 @@
136136 // Bucket settings for links to the feedback form
137137 $wgArticleFeedbackv5LinkBuckets = array(
138138 // Users can fall into one of several buckets for links. These are:
139 - // -: No link; user must scroll to the bottom of the page
 139+ // X: No link; user must scroll to the bottom of the page
140140 // A: After the site tagline (below the article title)
141141 // B: Below the titlebar on the right
142142 // C: Button fixed to right side
@@ -145,7 +145,7 @@
146146 // G: Button below logo
147147 // H: Link on each section bar
148148 'buckets' => array(
149 - '-' => 33,
 149+ 'X' => 33,
150150 'A' => 33,
151151 'B' => 0,
152152 'C' => 0,
@@ -158,7 +158,7 @@
159159 // This version number is added to all tracking event names, so that
160160 // changes in the software don't corrupt the data being collected. Bump
161161 // this when you want to start a new "experiment".
162 - 'version' => 2,
 162+ 'version' => 3,
163163 // Let users be tracked for a month, and then rebucket them, allowing some
164164 // churn.
165165 'expires' => 30,

Status & tagging log