r114368 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114367‎ | r114368 | r114369 >
Date:13:51, 21 March 2012
Author:maxsem
Status:ok
Tags:
Comment:
Follow-up r114344: fixed outdated comment, removed a couple of unused vars
Modified paths:
  • /trunk/extensions/InterfaceConcurrency/includes/ConcurrencyCheck.php (modified) (history)

Diff [purge]

Index: trunk/extensions/InterfaceConcurrency/includes/ConcurrencyCheck.php
@@ -61,8 +61,6 @@
6262 $userId = $this->user->getId();
6363 $cacheKey = wfMemcKey( 'concurrencycheck', $this->resourceType, $record );
6464
65 - global $wgInterfaceConcurrencyConfig;
66 -
6765 // check the cache first.
6866 $cached = $wgMemc->get( $cacheKey );
6967 if ( $cached ) {
@@ -150,7 +148,7 @@
151149 }
152150
153151 // replace is used here to support the override parameter
154 - $res = $dbw->replace(
 152+ $dbw->replace(
155153 'concurrencycheck',
156154 array( 'cc_resource_type', 'cc_record' ),
157155 array(
@@ -413,7 +411,6 @@
414412 * attempted.
415413 *
416414 * @param $checkoutInfo array (optional) of checkout information to store
417 - * @return array
418415 */
419416 protected function setCheckoutResult( $checkoutInfo = array() ) {
420417 $this->lastCheckout = $checkoutInfo;

Sign-offs

UserFlagDate
Nikerabbitinspected16:01, 21 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114344Resolve issues with r109666: mixing getters and setters in the same function ...demon03:36, 21 March 2012

Status & tagging log