r114329 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114328‎ | r114329 | r114330 >
Date:23:10, 20 March 2012
Author:rsterbin
Status:ok
Tags:
Comment:
Followup to r114064 -- fixed scope leakage
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -3481,7 +3481,7 @@
34823482 * Adds the trigger links to the page
34833483 */
34843484 $.articleFeedbackv5.addTriggerLinks = function () {
3485 - hasTipsy = false;
 3485+ var hasTipsy = false;
34863486 for ( var i in $.articleFeedbackv5.selectedLinks ) {
34873487 var linkId = $.articleFeedbackv5.selectedLinks[i];
34883488 if ( linkId in $.articleFeedbackv5.triggerLinks ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114064Brought trigger links into the plugin itself; styled flyover panel:...rsterbin20:44, 17 March 2012

Status & tagging log