r114303 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114302‎ | r114303 | r114304 >
Date:20:22, 20 March 2012
Author:rsterbin
Status:ok
Tags:
Comment:
Updated styling of Link Option E to match requirements
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/1x1_tab_blue.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/flyover_x.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/tab_x_off.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/tab_x_on.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/flyover_x.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/flyover_x.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/1x1_tab_blue.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/1x1_tab_blue.png
___________________________________________________________________
Added: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/tab_x_on.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/tab_x_on.png
___________________________________________________________________
Added: svn:mime-type
33 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/tab_x_off.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/tab_x_off.png
___________________________________________________________________
Added: svn:mime-type
44 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -1110,13 +1110,15 @@
11111111 border: none;
11121112 border-top: 1px solid gray;
11131113 border-left: 1px solid gray;
1114 - color: #000;
1115 - background-color: #d0e1f4;
 1114+ background-color: #255fa3;
 1115+ /* @embed */
 1116+ background-image: url(images/1x1_tab_blue.png);
 1117+ color: #fff;
11161118 min-width: 105px;
11171119 right: 0;
11181120 display: block;
11191121 margin: 0;
1120 - padding: 5px 10px;
 1122+ padding: 5px 25px;
11211123 text-align: center;
11221124 position: absolute;
11231125 z-index: 999;
@@ -1124,8 +1126,12 @@
11251127 .articleFeedbackv5-bottomrighttablink:hover {
11261128 text-decoration: none;
11271129 }
 1130+.articleFeedbackv5-bottomrighttablink a {
 1131+ color: #fff;
 1132+}
11281133 .articleFeedbackv5-bottomrighttablink.articleFeedbackv5-closeable {
11291134 white-space: nowrap;
 1135+ padding-right: 10px;
11301136 }
11311137
11321138 /* Disable flyover */
@@ -1152,7 +1158,7 @@
11531159 margin-top: -11px;
11541160 }
11551161 .articleFeedbackv5-disable-flyover {
1156 - padding: 10px;
 1162+ padding: 15px 20px;
11571163 }
11581164 .articleFeedbackv5-flyover-header {
11591165 -moz-border-radius: 3px 3px 0 0;
@@ -1170,20 +1176,22 @@
11711177 display: block;
11721178 position: absolute;
11731179 top: 0;
1174 - right: 15px;
1175 - margin-top: 15px;
 1180+ right: 20px;
 1181+ margin-top: 22px;
11761182 width: 16px;
11771183 height: 16px;
11781184 /* @embed */
1179 - background-image: url(images/bg-close-off.png);
 1185+ background-image: url(images/flyover_x.png);
11801186 background-repeat: no-repeat;
11811187 background-position: left top;
1182 - background-size: 16px 16px;
11831188 }
1184 -#articleFeedbackv5-noteflyover-close:hover {
1185 - /* @embed */
1186 - background-image: url(images/bg-close-hov.png);
 1189+
 1190+.tipsy.articleFeedbackv5-disable-flyover-tip-E {
 1191+ position: fixed;
11871192 }
 1193+
 1194+/* Trigger link close button */
 1195+
11881196 .articleFeedbackv5-trigger-link-holder .articleFeedbackv5-close-trigger-link {
11891197 visibility: hidden;
11901198 }
@@ -1202,6 +1210,19 @@
12031211 height: 16px;
12041212 vertical-align: middle;
12051213 }
1206 -.tipsy.articleFeedbackv5-disable-flyover-tip-E {
1207 - position: fixed;
 1214+
 1215+.articleFeedbackv5-trigger-link-holder.articleFeedbackv5-trigger-link-holder-E .articleFeedbackv5-close-trigger-link {
 1216+ /* @embed */
 1217+ background-image: url(images/tab_x_off.png);
 1218+ background-size: auto;
 1219+ background-position: center;
 1220+ display: inline-block;
 1221+ width: 16px;
 1222+ height: 16px;
 1223+ visibility: visible;
 1224+ margin-left: 5px;
12081225 }
 1226+.articleFeedbackv5-trigger-link-holder.articleFeedbackv5-trigger-link-holder-E:hover .articleFeedbackv5-close-trigger-link {
 1227+ /* @embed */
 1228+ background-image: url(images/tab_x_on.png);
 1229+}

Status & tagging log