r114245 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114244‎ | r114245 | r114246 >
Date:10:15, 20 March 2012
Author:jdlrobson
Status:reverted (Comments)
Tags:
Comment:
remove height 100%

not sure what purpose this is serving
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -2,7 +2,6 @@
33 body {
44 margin: 0;
55 padding: 0;
6 - height: 100%;
76 }
87
98 html {
@@ -156,14 +155,6 @@
157156 -webkit-appearance: none;
158157 }
159158
160 -ul#footer-info {
161 - list-style: none;
162 - list-style-image: none;
163 - list-style-type: none;
164 - margin: 0;
165 - padding: 0;
166 -}
167 -
168159 .divclearable {
169160 display: block;
170161 zoom: 1;
@@ -352,6 +343,15 @@
353344 transition: max-height 0.2s ease-in;
354345 }
355346
 347+/*
 348+disable animations in footer
 349+this is so that toggling can scroll it into view
 350+*/
 351+.togglingEnabled #footer .content_block {
 352+ -webkit-transition: none;
 353+ transition: none;
 354+}
 355+
356356 .togglingEnabled .openSection.section_anchors {
357357 display: block;
358358 }
@@ -488,11 +488,6 @@
489489 color: blue;
490490 }
491491
492 -.links {
493 - float: left;
494 - padding: 10px;
495 -}
496 -
497492 #contentSub,
498493 .dablink {
499494 margin-bottom: 10px;
@@ -500,6 +495,7 @@
501496
502497 #firstHeading {
503498 font-size: 1.7em;
 499+ margin: 0;
504500 }
505501
506502 .section_anchors a {
@@ -561,6 +557,11 @@
562558 float: left;
563559 }
564560
 561+.floatright::after,
 562+.floatleft::after {
 563+ clear: both;
 564+}
 565+
565566 #content_wrapper.home h1#firstHeading {
566567 display: none;
567568 }
@@ -572,6 +573,7 @@
573574 }
574575
575576 #content_wrapper {
 577+ position: relative;
576578 clear: both;
577579 margin: 22px 22px;
578580 }
@@ -586,11 +588,6 @@
587589 margin: 0;
588590 }
589591
590 -#footer {
591 - margin: 0 8px;
592 - clear: both;
593 -}
594 -
595592 #logo {
596593 position: absolute;
597594 height: 22px;
@@ -730,20 +727,7 @@
731728 margin: 8px 0 8px -3px;
732729 }
733730
734 -#footer {
735 - padding-top: 1em;
736 -}
737731
738 -#footer #perm {
739 - padding-top: 2em;
740 - font-size: 90%;
741 -}
742 -
743 -#footer #copyright {
744 - padding: 1em 0;
745 - font-size: 80%;
746 -}
747 -
748732 ol.references > li:target,
749733 sup.reference:target,
750734 span.citation:target,
@@ -885,11 +869,104 @@
886870 display: none !important;
887871 }
888872
 873+#footer {
 874+ -webkit-box-shadow: 0px -20px 10px -16px #ddd;
 875+ -moz-box-shadow: 0px -20px 10px -16px #ddd;
 876+ -o-box-shadow: 0px -20px 10px -16px #ddd;
 877+ box-shadow: 0px -20px 10px -16px #ddd;
 878+ padding: 12px 22px; /* see content_wrapper margin */
 879+ border-top: solid 1px #aaa;
 880+ line-height: 24px;
 881+ position: relative;
 882+ clear: both; /* cancel any floating in the content */
 883+}
 884+
 885+#footer ul {
 886+ text-align: center;
 887+ width: 100%;
 888+ padding: 0;
 889+ list-style: none;
 890+}
 891+
 892+#footer img {
 893+ height: 23px;
 894+ float: left;
 895+ margin-right: 4px;
 896+}
 897+
 898+#footer .toggleCopyright,
 899+#footer .license {
 900+ font-weight: bold;
 901+ font-size: 1em;
 902+ line-height: 24px;
 903+}
 904+
 905+#footer .toggleCopyright {
 906+ float: right;
 907+ margin: 0;
 908+ padding: 0;
 909+ position: relative;
 910+ padding-right: 32px;
 911+}
 912+
 913+.toggleCopyright .hide,
 914+.toggleCopyright .show {
 915+ position: absolute;
 916+ top: 0;
 917+ right: 0;
 918+ height: 22px;
 919+}
 920+
 921+.copyrightNotice {
 922+ padding-top: 8px;
 923+ line-height: 1.2em;
 924+ margin-bottom: 12px;
 925+}
 926+
 927+#content_copyright {
 928+ text-align: center;
 929+ font-size: 0.9em;
 930+}
 931+
 932+#footer .links {
 933+ margin: 0;
 934+}
 935+
 936+#footer .links li {
 937+ display: block;
 938+ width: 25%;
 939+ font-size: 1.2em;
 940+ float: left;
 941+ text-align: center;
 942+}
 943+
 944+#footer .links li:first-child {
 945+ text-align: left;
 946+}
 947+
 948+#footer .links li:last-child {
 949+ text-align: right;
 950+}
 951+
 952+#footer .links:after {
 953+ content: "";
 954+ clear: both;
 955+ position: relative;
 956+ display: block;
 957+}
 958+
 959+.togglingEnabled #footer .more,
 960+.togglingEnabled #footer .openSection .less {
 961+ display: block;
 962+}
 963+
 964+#footer .more, /* no javascript */
 965+#footer .less,
 966+#footer .openSection .more {
 967+ display: none;
 968+}
 969+
889970 #mf-references {
890 - -webkit-transition: bottom 0.1s ease-in-out;
891 - -moz-transition: bottom 0.1s ease-in-out;
892 - -o-transition: bottom 0.1s ease-in-out;
893 - transition: bottom 0.1s ease-in-out;
894971 position: fixed;
895972 bottom: 0;
896973 left: 0;
@@ -931,3 +1008,53 @@
9321009 #mf-references a {
9331010 color: #3354C0;
9341011 }
 1012+
 1013+.feedback h1 {
 1014+ margin: 0;
 1015+ margin-bottom: 20px;
 1016+ border-bottom: solid 1px #CCC;
 1017+ padding-bottom: 10px;
 1018+}
 1019+
 1020+.feedback select {
 1021+ height: 35px;
 1022+}
 1023+
 1024+.feedback .saveEmail {
 1025+ float: right;
 1026+ color: #9C9C9C;
 1027+}
 1028+.feedback input[type=submit],
 1029+.feedback select {
 1030+ background-color: #5E5E5E;
 1031+ padding: 12px;
 1032+ color: white;
 1033+ display: block;
 1034+ margin: 22px 0px;
 1035+ border: none;
 1036+ -webkit-border-radius: 2px;
 1037+ border-radius: 2px;
 1038+ -webkit-box-shadow: 3px 3px 3px #8C8C8C;
 1039+ font-size: 1.5em;
 1040+}
 1041+
 1042+.feedback input.email {
 1043+ height: 38px;
 1044+}
 1045+
 1046+.feedback textarea,
 1047+.feedback input.email {
 1048+ /*padding: 12px;*/
 1049+ width: 100%;
 1050+ border: solid 1px #888888;
 1051+}
 1052+
 1053+.feedback textarea,
 1054+.feedback input {
 1055+ font-size: 1.5em;
 1056+}
 1057+
 1058+.feedback input::-webkit-input-placeholder,
 1059+.feedback textarea::-webkit-input-placeholder {
 1060+ color: #747474;
 1061+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r114246rv r114245 at jdlrobson's requestmaxsem10:34, 20 March 2012

Comments

#Comment by Jdlrobson (talk | contribs)   10:24, 20 March 2012

Sorry some where between running a diff and doing a commit my local copy changed. Will revert this change.

Status & tagging log