r114217 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114216‎ | r114217 | r114218 >
Date:23:36, 19 March 2012
Author:qchris
Status:ok
Tags:
Comment:
Follow up to r114126: Being more conservative for HipHop compiler
Modified paths:
  • /trunk/phase3/includes/parser/Preprocessor_HipHop.hphp (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Preprocessor_HipHop.hphp
@@ -444,7 +444,8 @@
445445 } elseif ( $found === 'line-end' ) {
446446 $piece = $stack->getTop();
447447 // A heading must be open, otherwise \n wouldn't have been in the search list
448 - assert( '$piece->open === "\n"' );
 448+ assert( $piece->open === "\n" ); // Passing the assert condition directly instead of string, as
 449+ // HPHP /compiler/ chokes on strings when ASSERT_ACTIVE != 0.
449450 $part = $piece->getCurrentPart();
450451 // Search back through the input to see if it has a proper close
451452 // Do this using the reversed string since the other solutions (end anchor, etc.) are inefficient

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r114126Sanitizing already existing use of PHP's assertqchris11:14, 19 March 2012

Status & tagging log